Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow extension yang.settings JSON Schema extensibility #243

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Allow extension yang.settings JSON Schema extensibility #243

merged 2 commits into from
Jun 18, 2024

Conversation

esmasth
Copy link
Contributor

@esmasth esmasth commented Apr 23, 2024

This addresses #242

@esmasth
Copy link
Contributor Author

esmasth commented Apr 23, 2024

@dhuebner request your review here

@esmasth
Copy link
Contributor Author

esmasth commented Jun 17, 2024

@dhuebner is this change fine to integrate?

dhuebner
dhuebner approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@dhuebner dhuebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@dhuebner dhuebner merged commit 3697fbd into TypeFox:master Jun 18, 2024
2 checks passed
@esmasth esmasth deleted the esmasth/issue242 branch June 18, 2024 19:04
@esmasth esmasth mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuebner dhuebner dhuebner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esmasth @dhuebner