Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for absolute paths exclusion #232

Closed
esmasth opened this issue Feb 26, 2024 · 1 comment
Closed

Support for absolute paths exclusion #232

esmasth opened this issue Feb 26, 2024 · 1 comment

Comments

@esmasth
Copy link
Contributor

esmasth commented Feb 26, 2024

Currently excludePath only supports relative paths, and it is seemingly presumed that yangPath is always provisioned with a directory which does not contain unwanted duplicates.

It would be very helpful for our use case, if there is support added for excludePath with absolute paths as well as it is ensured that if an excludePath is a subdirectory of any of yangPath directories then it is removed from the indexing.

Alternatively, an additional variable is introduced e.g., yangPathIgnore, which is used to ignore (sub)directories out of what's provided via yangPath

esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 1, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also formatted markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 2, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 9, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 12, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
esmasth added a commit to esmasth/yang-lsp that referenced this issue Apr 12, 2024
This allows for exclusion of specific subdirs or files under the dirs
specified via `yangPath`.

Also added github ci checks markdown files to fix markdownlint issues.

This addresses TypeFox#232

Signed-off-by: Siddharth Sharma <[email protected]>
@esmasth esmasth changed the title Support for absolute paths in yang.settings excludePath Support for absolute paths exclusion Apr 12, 2024
@esmasth
Copy link
Contributor Author

esmasth commented Apr 16, 2024

#240 addressed this issue

@esmasth esmasth closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant