Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI/CD build issues #583

Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: lint issues
feat: export the following
- DefaultHyperlinkToolbar
- EditHyperlinkMenu
troglodytto committed Feb 16, 2024

Verified

This commit was signed with the committer’s verified signature.
troglodytto Ephemeral Astronaut
commit c379c0f3a4b0acc8b8e7d09b5a99b281413d8c31
4 changes: 4 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion packages/dev-scripts/examples/gen.ts
Original file line number Diff line number Diff line change
@@ -50,7 +50,9 @@ async function writeTemplate(project: Project, templateFile: string) {

try {
// fs.unlinkSync(targetFilePath);
} catch (e) {}
} catch (e) {
// ignore any errors
}
console.log("written", targetFilePath);
}

11 changes: 7 additions & 4 deletions packages/dev-scripts/package.json
Original file line number Diff line number Diff line change
@@ -11,17 +11,20 @@
"gen:examples": "tsx examples/gen.ts",
"gen:docs": "tsx examples/genDocs.ts",
"build": "tsc",
"lint": "eslint src --max-warnings 0"
"lint": "eslint **/*.ts{,x} --max-warnings 0"
},
"dependencies": {},
"devDependencies": {
"@types/react": "^18.0.25",
"@types/react-dom": "^18.0.9",
"eslint": "^8.10.0",
"glob": "^10.3.10",
"prettier": "^2.7.1",
"typescript": "^5.0.4",
"tsx": "^4.6.2",
"glob": "^10.3.10"
"typescript": "^5.0.4"
},
"dependencies": {
"react": "^18",
"react-dom": "^18"
},
"peerDependencies": {
"react": "^18",
2 changes: 2 additions & 0 deletions packages/react/src/index.ts
Original file line number Diff line number Diff line change
@@ -15,6 +15,8 @@ export * from "./components/FormattingToolbar/DefaultFormattingToolbar";
export * from "./components/FormattingToolbar/FormattingToolbarPositioner";

export * from "./components/HyperlinkToolbar/HyperlinkToolbarPositioner";
export * from "./components/HyperlinkToolbar/DefaultHyperlinkToolbar";
export * from "./components/HyperlinkToolbar/EditHyperlinkMenu/components/EditHyperlinkMenu";

export * from "./components/SideMenu/DefaultButtons/AddBlockButton";
export * from "./components/SideMenu/DefaultButtons/DragHandle";
5 changes: 4 additions & 1 deletion playground/src/main.tsx
Original file line number Diff line number Diff line change
@@ -99,7 +99,10 @@ const App = (props: { project: (typeof examples)[0]["projects"][0] }) => {
if (!ExampleComponent) {
return <div>Loading...</div>;
}
return <ExampleComponent.default />;

const LoadedExampleComponent = ExampleComponent.default;

return <LoadedExampleComponent />;
};

const router = createBrowserRouter([