-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mentions & custom suggestion menus #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jan 16, 2024
...defaultInlineContentSpecs, | ||
mention: MentionInlineContent, | ||
} satisfies InlineContentSpecs; | ||
const customInlineContentSchema = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed?
DefaultStyleSchema | ||
> | ||
) => { | ||
editor._tiptapEditor.commands.insertContent({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to discuss
packages/core/src/extensions-shared/suggestion/SuggestionPlugin.ts
Outdated
Show resolved
Hide resolved
* fix: Docs home page demo styling fix (#507) * Fixed styling for code styles (#517) * Made suggestions plugin control multiple menus * Added hook to create suggestion menu * Fixed add block button behaviour on blocks with different content (#526) * Small CSS fix (#527) * fix: List item shortcuts (#528) * Fixed list item shortcuts * Updated test screenshots * Added code toggle formatting toolbar example (#531) * fix: Errors when hovering image block while editor is uneditable (#533) * Fixed errors when hovering image block while editor is uneditable * Small fix * fix: Formatting toolbar not hiding while dragging blocks (#529) * Fixed formatting toolbar not hiding while dragging blocks * Small fix * Updated Mantine (#535) * Updated `package-lock.json` (#536) * v0.11.1 * v0.6.2 * v0.8.1 * v0.8.2 * v0.8.3 * v0.8.4 * v0.8.5 * v0.9.0 * v0.9.1 * Revert "v0.9.1" This reverts commit 6e9d61f. * v0.9.1 * Revert "v0.9.1" This reverts commit ac7abee. * v0.9.2 * v0.9.3 * v0.9.4 * v0.9.5 * v0.9.6 * v0.10.0 * v0.10.1 * v0.11.0 * v0.11.1 * fix collaboration and editable: false bug (#538) * pair refactoring * wip * fix type annotations on some of the docs (#539) * Cleanup and continue refactor * docs: Dark mode styling fix (#548) * Fixed styles that were overwritten by Mantine globals * Removed old code * Implemented PR feedback * Add Liveblocks info and BlockNote download command (#540) * Update real-time-collaboration.md * feat: Example image * feat: Replace image with video * Fixed video --------- Co-authored-by: Matthew Lipski <[email protected]> * Implemented PR feedback * fix: Mantine styles (#553) * Updated Mantine and package-lock * Added Mantine global styles reset * Made Mantine global styles not get imported * Fixed CSS import order * Updated test & snapshots * Implemented PR feedback * Implemented PR feedback * Fixed paragraph shortcut (#556) * v0.11.2 * Fixed build issues * Fixed add block button behaviour * Small fix * Small fix * Fixed tests --------- Co-authored-by: Yousef <[email protected]> Co-authored-by: Chris Nicholas <[email protected]>
…or' into mentions-suggestions-getitems
…ns-getitems # Conflicts: # packages/react/src/components/SuggestionMenu/DefaultPositionedSuggestionMenu.tsx # packages/react/src/index.ts
feat: UI element creation API
…into mentions-suggestions
58 tasks
58 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.