feat: Asynchronous slash menu item fetching #506
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED
reviewed
Jan 11, 2024
packages/core/src/extensions-shared/suggestion/SuggestionPlugin.ts
Outdated
Show resolved
Hide resolved
YousefED
reviewed
Jan 15, 2024
58 tasks
58 tasks
|
See https://www.blocknotejs.org/docs/ui-components/suggestion-menus for the
new docs :)
…On Tue, Mar 5, 2024 at 2:49 PM Matthew Lipski ***@***.***> wrote:
Closed #506 <#506> via #609
<#609>.
—
Reply to this email directly, view it on GitHub
<#506 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2BWLEZII4ZTNSWXIMQJ3YWXENDAVCNFSM6AAAAABBUAUJJ6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGAYTIMJZHE2TENY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the suggestion plugin to support fetching items asynchronously. To do this, some of the existing responsibility of the suggestion plugin has to be move. Specifically, the keyboard handling is moved to the slash menu component and item filtering is moved to the function provided in the
slashMenuItemsoption.I think we can move the plugin state to the plugin view like it is in the table handles plugin, though this is still TODO.
Closes #488