Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve code architechture #175

Closed
6 tasks done
Type-Style opened this issue Oct 8, 2024 · 0 comments · Fixed by #177
Closed
6 tasks done

improve code architechture #175

Type-Style opened this issue Oct 8, 2024 · 0 comments · Fixed by #177
Assignees
@Type-Style
Labels
enhancement New feature or request Research Need to collect further information

Comments

@Type-Style
Copy link
Owner

Type-Style commented Oct 8, 2024 •
edited
Loading

  • move getData to seperate file
  • don't use useEffect to fetch data
  • research about usesyncexternalstore
  • split loading lazy
  • load map only when logged in load map when userData but keep after logged out
  • reduce webpack bundle-size
@Type-Style Type-Style added enhancement New feature or request Research Need to collect further information labels Oct 8, 2024
@Type-Style Type-Style self-assigned this Oct 8, 2024
@Type-Style Type-Style moved this from Todo to In Progress in Lorex Board Oct 8, 2024
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Task] #175, improve imports
51c8eb2
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Task] #175, remove console logs
87ce5ac
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Task] #175, add returnObj Type for data fetching
1b37557
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Change] #175, extracted data fetching to seperate file
b29645a
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Change] #175, speed calculation to harmonic mean
de0be59
Type-Style added a commit that referenced this issue Oct 11, 2024
@Type-Style
[Change] #175, speed calculation to harmonic mean
e38f3b2
Type-Style added a commit that referenced this issue Oct 14, 2024
@Type-Style
[Task] #175, code architechture, lazy loading, named imports reduce b…
32260c5 
…undle size
Type-Style added a commit that referenced this issue Oct 14, 2024
@Type-Style
[Task] #175, code architechture, reduce bundle size
1e97384
@Type-Style Type-Style linked a pull request Oct 14, 2024 that will close this issue
175 improve code architechture #177
Merged
Type-Style added a commit that referenced this issue Oct 14, 2024
@Type-Style
[Task] #175, code architechture, cleanup unused imports
c28c450
Type-Style added a commit that referenced this issue Oct 14, 2024
@Type-Style
[Task] #175, code architechture, cleanup unused imports
6c6e78a
Type-Style added a commit that referenced this issue Oct 14, 2024
@Type-Style
[Task] #175, code architechture, cleanup unused imports
953496f
@github-project-automation github-project-automation bot moved this from In Progress to Done in Lorex Board Oct 14, 2024
Type-Style added a commit that referenced this issue Oct 16, 2024
@Type-Style
[Task] #175, code architechture, prevent inconsisten render, show imp…
471c47c 
…roved error messages,
Type-Style added a commit that referenced this issue Oct 16, 2024
@Type-Style
[Task] #175, show created time when logged out
243f6ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Type-Style Type-Style

Labels
enhancement New feature or request Research Need to collect further information
Projects
Lorex Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

175 improve code architechture Type-Style/LOREX
1 participant
@Type-Style