Merging to release-5.3: [TT-13608] Issues with custom scalar in query variable (#6766) #6768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-13608" title="TT-13608" target="_blank">TT-13608</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Issues with custom scalar in query variable</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Code Review</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20'24Bugsmash%20ORDER%20BY%20created%20DESC" title="'24Bugsmash">'24Bugsmash</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC" title="jira_escalated">jira_escalated</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- This PR updates graphql-go-tools dependency. Related PR: TykTechnologies/graphql-go-tools#434 ___ Bug fix, Dependencies ___ - Updated the `graphql-go-tools` dependency in `go.mod` to a newer version (`v1.6.2-0.20241212110213-7724a3b64bb2`). - Updated corresponding hash values in `go.sum` to reflect the new dependency version. - This update addresses issues with custom scalar handling in query variables. ___ <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table> <tr> <td> <details> <summary><strong>go.mod</strong><dd><code>Update `graphql-go-tools` dependency version in `go.mod`.</code></dd></summary> <hr> go.mod <li>Updated the <code>graphql-go-tools</code> dependency to a newer version.<br> <li> Changed the version from <code>v1.6.2-0.20240926103032-6eca9f4b5e30</code> to <br><code>v1.6.2-0.20241212110213-7724a3b64bb2</code>.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6766/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>go.sum</strong><dd><code>Update dependency hash values in `go.sum`.</code> </dd></summary> <hr> go.sum <li>Updated hash values for the <code>graphql-go-tools</code> dependency to match the <br>new version.<br> <li> Replaced old hash values with those corresponding to the updated <br>version.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6766/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+2/-2</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information (cherry picked from commit f48eb98)
|
API Changes no api changes detected |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
|
buraksezer
deleted the
merge/release-5.3/f48eb98026a304ac0f7ae79aededee6cb707e846
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
TT-13608 Issues with custom scalar in query variable (#6766)
User description
TT-13608
This PR updates graphql-go-tools dependency.
Related PR: TykTechnologies/graphql-go-tools#434
PR Type
Bug fix, Dependencies
Description
graphql-go-toolsdependency ingo.modto a newerversion (
v1.6.2-0.20241212110213-7724a3b64bb2).go.sumto reflect the newdependency version.
variables.
Changes walkthrough 📝
go.mod
Update `graphql-go-tools` dependency version in `go.mod`.go.mod
graphql-go-toolsdependency to a newer version.v1.6.2-0.20240926103032-6eca9f4b5e30tov1.6.2-0.20241212110213-7724a3b64bb2.go.sum
Update dependency hash values in `go.sum`.go.sum
graphql-go-toolsdependency to match thenew version.
version.
PR Type
Bug fix, Dependencies
Description
graphql-go-toolsdependency ingo.modto versionv1.6.2-0.20241212110213-7724a3b64bb2to address issues with custom scalar handling in query variables.go.sumto reflect the new dependency version.github.com/coder/websocketingo.modand its hash values ingo.sum.graphql-translatoringo.mod.Changes walkthrough 📝
go.mod
Update dependencies in `go.mod` for bug resolution.go.mod
graphql-go-toolsdependency to a newer version.github.com/coder/websocket.graphql-translator.go.sum
Update dependency hash values in `go.sum`.go.sum
graphql-go-toolsdependency to reflect thenew version.
github.com/coder/websocket.