Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-5.7: [TT-13608] Issues with custom scalar in query variable (#6766) #6767

Merged

Conversation

buger
Copy link
Member

@buger buger commented Dec 12, 2024

User description

TT-13608 Issues with custom scalar in query variable (#6766)

User description

TT-13608
Summary Issues with custom scalar in query variable
Type Bug Bug
Status In Code Review
Points N/A
Labels '24Bugsmash, jira_escalated

This PR updates graphql-go-tools dependency.

Related PR: TykTechnologies/graphql-go-tools#434


PR Type

Bug fix, Dependencies


Description

  • Updated the graphql-go-tools dependency in go.mod to a newer
    version (v1.6.2-0.20241212110213-7724a3b64bb2).
  • Updated corresponding hash values in go.sum to reflect the new
    dependency version.
  • This update addresses issues with custom scalar handling in query
    variables.

Changes walkthrough 📝

Relevant files
Dependencies
go.mod
Update `graphql-go-tools` dependency version in `go.mod`.

go.mod

  • Updated the graphql-go-tools dependency to a newer version.
  • Changed the version from v1.6.2-0.20240926103032-6eca9f4b5e30 to
    v1.6.2-0.20241212110213-7724a3b64bb2.
  • +1/-1     
    go.sum
    Update dependency hash values in `go.sum`.                             

    go.sum

  • Updated hash values for the graphql-go-tools dependency to match the
    new version.
  • Replaced old hash values with those corresponding to the updated
    version.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull
    request to receive relevant information


    PR Type

    Bug fix, Dependencies


    Description

    • Updated the graphql-go-tools dependency in go.mod to a newer version (v1.6.2-0.20241212110213-7724a3b64bb2).
    • Updated corresponding hash values in go.sum to reflect the new dependency version.
    • This update addresses issues with custom scalar handling in query variables.

    Changes walkthrough 📝

    Relevant files
    Dependencies
    go.mod
    Update `graphql-go-tools` dependency version in `go.mod`.

    go.mod

  • Updated the graphql-go-tools dependency version.
  • Changed version from v1.6.2-0.20240926103032-6eca9f4b5e30 to
    v1.6.2-0.20241212110213-7724a3b64bb2.
  • +1/-1     
    go.sum
    Update dependency hash values in `go.sum`.                             

    go.sum

  • Updated hash values for the graphql-go-tools dependency.
  • Replaced old hash values with those corresponding to the updated
    version.
  • +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    ### **User description**
    <details open>
    <summary><a href="https://tyktech.atlassian.net/browse/TT-13608"
    title="TT-13608" target="_blank">TT-13608</a></summary>
      <br />
      <table>
        <tr>
          <th>Summary</th>
          <td>Issues with custom scalar in query variable</td>
        </tr>
        <tr>
          <th>Type</th>
          <td>
    <img alt="Bug"
    src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium"
    />
            Bug
          </td>
        </tr>
        <tr>
          <th>Status</th>
          <td>In Code Review</td>
        </tr>
        <tr>
          <th>Points</th>
          <td>N/A</td>
        </tr>
        <tr>
          <th>Labels</th>
    <td><a
    href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20'24Bugsmash%20ORDER%20BY%20created%20DESC"
    title="'24Bugsmash">'24Bugsmash</a>, <a
    href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC"
    title="jira_escalated">jira_escalated</a></td>
        </tr>
      </table>
    </details>
    <!--
      do not remove this marker as it will break jira-lint's functionality.
      added_by_jira_lint
    -->
    
    ---
    
    This PR updates graphql-go-tools dependency.
    
    Related PR: TykTechnologies/graphql-go-tools#434
    
    
    ___
    
    ### **PR Type**
    Bug fix, Dependencies
    
    
    ___
    
    ### **Description**
    - Updated the `graphql-go-tools` dependency in `go.mod` to a newer
    version (`v1.6.2-0.20241212110213-7724a3b64bb2`).
    - Updated corresponding hash values in `go.sum` to reflect the new
    dependency version.
    - This update addresses issues with custom scalar handling in query
    variables.
    
    
    
    ___
    
    
    
    ### **Changes walkthrough** 📝
    <table><thead><tr><th></th><th align="left">Relevant
    files</th></tr></thead><tbody><tr><td><strong>Dependencies</strong></td><td><table>
    <tr>
      <td>
        <details>
    <summary><strong>go.mod</strong><dd><code>Update `graphql-go-tools`
    dependency version in `go.mod`.</code></dd></summary>
    <hr>
    
    go.mod
    
    <li>Updated the <code>graphql-go-tools</code> dependency to a newer
    version.<br> <li> Changed the version from
    <code>v1.6.2-0.20240926103032-6eca9f4b5e30</code> to
    <br><code>v1.6.2-0.20241212110213-7724a3b64bb2</code>.<br>
    
    
    </details>
    
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6766/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6">+1/-1</a>&nbsp;
    &nbsp; &nbsp; </td>
    
    </tr>
    
    <tr>
      <td>
        <details>
    <summary><strong>go.sum</strong><dd><code>Update dependency hash values
    in `go.sum`.</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
    &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
    <hr>
    
    go.sum
    
    <li>Updated hash values for the <code>graphql-go-tools</code> dependency
    to match the <br>new version.<br> <li> Replaced old hash values with
    those corresponding to the updated <br>version.<br>
    
    
    </details>
    
    
      </td>
    <td><a
    href="https://github.com/TykTechnologies/tyk/pull/6766/files#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63">+2/-2</a>&nbsp;
    &nbsp; &nbsp; </td>
    
    </tr>
    </table></td></tr></tr></tbody></table>
    
    ___
    
    > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull
    request to receive relevant information
    
    (cherry picked from commit f48eb98)
    @buger buger merged commit 7e2a16b into release-5.7 Dec 12, 2024
    @buger buger deleted the merge/release-5.7/f48eb98026a304ac0f7ae79aededee6cb707e846 branch December 12, 2024 12:25
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis 🔶

    6766 - Partially compliant

    Fully compliant requirements:

    • Update the graphql-go-tools dependency in go.mod to a newer version.
    • Update corresponding hash values in go.sum to reflect the new dependency version.

    Not compliant requirements:

    • Address issues with custom scalar handling in query variables.
    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Update
    Ensure the updated version of graphql-go-tools resolves the issues with custom scalar handling in query variables as intended.

    Dependency Hash Update
    Verify that the updated hash values in go.sum correctly correspond to the new version of graphql-go-tools.

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants