Merging to release-5.3: [TT-12775] Add request size limit test for POST, PUT and PATCH methods. (#6751) #6753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. (#6751) <details open> <summary><a href="https://tyktech.atlassian.net/browse/TT-12775" title="TT-12775" target="_blank">TT-12775</a></summary> <br /> <table> <tr> <th>Summary</th> <td>Request size limit breaks GET and DELETE requests</td> </tr> <tr> <th>Type</th> <td> <img alt="Bug" src="https://tyktech.atlassian.net/rest/api/2/universal_avatar/view/type/issuetype/avatar/10303?size=medium" /> Bug </td> </tr> <tr> <th>Status</th> <td>In Code Review</td> </tr> <tr> <th>Points</th> <td>N/A</td> </tr> <tr> <th>Labels</th> <td><a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20'24Bugsmash%20ORDER%20BY%20created%20DESC" title="'24Bugsmash">'24Bugsmash</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20customer_bug%20ORDER%20BY%20created%20DESC" title="customer_bug">customer_bug</a>, <a href="https://tyktech.atlassian.net/issues?jql=project%20%3D%20TT%20AND%20labels%20%3D%20jira_escalated%20ORDER%20BY%20created%20DESC" title="jira_escalated">jira_escalated</a></td> </tr> </table> </details> <!-- do not remove this marker as it will break jira-lint's functionality. added_by_jira_lint --> --- Follow up PR for #6734 This PR adds a negative test case for POST, PUT and PATCH methods. The test is more complex than the existing ones because Golang http package automatically adds `Content-Length` to request if the method is POST, PUT or PATCH. ___ Tests, Bug fix ___ - Added a new test case to ensure that requests without `Content-Length` headers for POST, PUT, and PATCH methods are correctly handled by the middleware. - Verified that the middleware returns `StatusLengthRequired` and logs an appropriate error message when the `Content-Length` header is missing. - Improved test coverage for request size limit functionality. ___ <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Tests</strong></td><td><table> <tr> <td> <details> <summary><strong>mw_request_size_limit_test.go</strong><dd><code>Add test case for missing Content-Length in POST, PUT, PATCH methods</code></dd></summary> <hr> gateway/mw_request_size_limit_test.go <li>Added a new test case to validate behavior when <code>Content-Length</code> is <br>missing for POST, PUT, and PATCH methods.<br> <li> Introduced a logger and middleware setup for the new test case.<br> <li> Verified that the middleware returns <code>StatusLengthRequired</code> and an <br>appropriate error message when <code>Content-Length</code> is missing.<br> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/6751/files#diff-107317fefc06776e7acf5e35daac311b025a92c6721432272dbd7c7dcdd854f8">+33/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: Comment `/help "your question"` on any pull request to receive relevant information (cherry picked from commit 9c5a43b)
|
API Changes no api changes detected |
|
buraksezer
deleted the
merge/release-5.3/9c5a43bcafb2ca81b38592e4f57d002f55f889d7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TT-12775 Add request size limit test for POST, PUT and PATCH methods. (#6751)
User description
TT-12775
Follow up PR for #6734
This PR adds a negative test case for POST, PUT and PATCH methods. The
test is more complex than the existing ones because Golang http package
automatically adds
Content-Lengthto request if the method is POST,PUT or PATCH.
PR Type
Tests, Bug fix
Description
Content-Lengthheaders for POST, PUT, and PATCH methods are correctly handled by the
middleware.
StatusLengthRequiredand logsan appropriate error message when the
Content-Lengthheader ismissing.
Changes walkthrough 📝
mw_request_size_limit_test.go
Add test case for missing Content-Length in POST, PUT, PATCH methodsgateway/mw_request_size_limit_test.go
Content-Lengthismissing for POST, PUT, and PATCH methods.
StatusLengthRequiredand anappropriate error message when
Content-Lengthis missing.