Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging to release-5.7: Fixes (#5850) #5851

Merged

Conversation

buger
Copy link
Member

@buger buger commented Dec 31, 2024

User description

Fixes (#5850)

fixes


PR Type

Documentation, Enhancement


Description

  • Updated the release date for version 5.7.1 in both Dashboard and Gateway release notes to "31 December 2024".
  • Enhanced the dashboard.json file by updating the latest and lts versions and adding detailed release information for version 5.7.1, including date and Docker link.
  • Enhanced the gateway.json file by updating the latest and lts versions and adding detailed release information for version 5.7.1, including date, tag, and Docker link.

Changes walkthrough 📝

Relevant files
Documentation
dashboard.md
Updated release date for Dashboard 5.7.1                                 

tyk-docs/content/developer-support/release-notes/dashboard.md

  • Updated the release date for version 5.7.1 to "31 December 2024".
+1/-1     
gateway.md
Updated release date for Gateway 5.7.1                                     

tyk-docs/content/developer-support/release-notes/gateway.md

  • Updated the release date for version 5.7.1 to "31 December 2024".
+1/-1     
Enhancement
dashboard.json
Added release details for Dashboard 5.7.1                               

tyk-docs/data/releases/dashboard.json

  • Updated latest version to "5.7.1".
  • Updated lts version to "5.3.9".
  • Added release details for version 5.7.1, including date and Docker
    link.
  • +6/-2     
    gateway.json
    Added release details for Gateway 5.7.1                                   

    tyk-docs/data/releases/gateway.json

  • Updated latest version to "5.7.1".
  • Updated lts version to "5.3.9".
  • Added release details for version 5.7.1, including date, tag, and
    Docker link.
  • +7/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    fixes
    
    (cherry picked from commit cc1b5c7)
    @buger buger enabled auto-merge (squash) December 31, 2024 06:05
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    🎫 Ticket compliance analysis ✅

    5850 - Fully compliant

    Fully compliant requirements:

    • Update the release date for version 5.7.1 in both Dashboard and Gateway release notes to "31 December 2024".
    • Enhance the dashboard.json file by updating the latest and lts versions and adding detailed release information for version 5.7.1, including date and Docker link.
    • Enhance the gateway.json file by updating the latest and lts versions and adding detailed release information for version 5.7.1, including date, tag, and Docker link.

    Not compliant requirements:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Possible Data Formatting Issue

    Ensure that the date format "31/12/2024" is consistent with other parts of the project and adheres to any existing standards or conventions.

    "5.7.1": {
      "date": "31/12/2024",
      "docker": "https://hub.docker.com/r/tykio/tyk-dashboard/tags?page=1&name=v5.7.1"
    }, 
    Possible Data Formatting Issue

    Ensure that the date format "31/12/2024" is consistent with other parts of the project and adheres to any existing standards or conventions.

    "5.7.1": {
      "date": "31/12/2024",
      "tag": "https://github.com/TykTechnologies/tyk/releases/tag/v5.7.1",
      "docker": "https://hub.docker.com/r/tykio/tyk-gateway/tags?page=1&name=v5.7.1"

    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link

    netlify bot commented Dec 31, 2024

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 5f1a4e0
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/677389b6c567130008943998
    😎 Deploy Preview https://deploy-preview-5851--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    1 similar comment
    Copy link

    netlify bot commented Dec 31, 2024

    PS. Pls add /docs/nightly to the end of url

    Name Link
    🔨 Latest commit 5f1a4e0
    🔍 Latest deploy log https://app.netlify.com/sites/tyk-docs/deploys/677389b6c567130008943998
    😎 Deploy Preview https://deploy-preview-5851--tyk-docs.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @buger buger merged commit 3a7acb9 into release-5.7 Dec 31, 2024
    9 checks passed
    @buger buger deleted the merge/release-5.7/cc1b5c77fc3d100ad3b5d6927a5433571f4603d2 branch December 31, 2024 06:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants