-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-1008, TT-11562] Updated Internal Endpoint middleware #4046
Conversation
PR Description updated to latest commit (001dd27) |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Analysis
PR Feedback💡 General suggestions: The PR is well-structured and the documentation updates are comprehensive and clear. It would be beneficial to ensure that all the new links in the documentation are working correctly and lead to the right places. Also, make sure that the new menu items are correctly displayed and accessible. 🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code SuggestionsNo suggestions found to improve this PR. ✨ Usage guide:Overview:
With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM Andy, I've suggested minor changes. Once images and placeholder videos are added and PR peer reviewed then willapprove and ready as ready for merge and release.
tyk-docs/content/advanced-configuration/transform-traffic/endpoint-designer.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted suggestions following review
tyk-docs/content/advanced-configuration/transform-traffic/endpoint-designer.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic.md
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
Co-authored-by: dcs3spp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Andy! PR LGTM, have resolved comments apart from image and video to add. Once peer reviewed and image and video has been added then we can mark as ready for release. I'll mark the PR as draft until image and video added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor improvements
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
Outdated
Show resolved
Hide resolved
@andyo-tyk To facilitate reviewing the PR queue we are closing some PRs that are in draft status, e.g. awaiting docker images, videos, images etc. You can still update the PR and then open it again when ready for review. cc: @letzya |
I spotted a typo and missing image in Ignore Auth, so picked these up in this PR as simple edits. |
PR Description updated to latest commit (0be9b0e) |
PR Review
Code feedback:✨ Review tool usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code SuggestionsNo code suggestions found for PR. |
User description
Preview Link
https://deploy-preview-4046--tyk-docs.netlify.app/docs/nightly/product-stack/tyk-gateway/middleware/internal-endpoint-middleware/
Description
Updated documentation of the Internal Endpoint middleware
Type
Documentation
Description
Changes walkthrough
endpoint-designer.md
Update Internal Endpoint middleware description in Endpoint Designer
documentation
tyk-docs/content/advanced-configuration/transform-traffic/endpoint-designer.md
internal-endpoint-middleware.md
Add Internal Endpoint middleware documentation
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
middleware.
internal-endpoint-tyk-classic.md
Add guide for using Internal Endpoint middleware with Tyk Classic APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic.md
Classic APIs.
internal-endpoint-tyk-oas.md
Add guide for using Internal Endpoint middleware with Tyk OAS APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
OAS APIs.
menu.yaml
Update menu with Internal Endpoint middleware documentation links
tyk-docs/data/menu.yaml
documentation.
✨ Usage guide:
Overview:
The
describe
tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.When commenting, to edit configurations related to the describe tool (
pr_description
section), use the following template:With a configuration file, use the following template:
Enabling\disabling automation
meaning the
describe
tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description.the tool will replace every marker of the form
pr_agent:marker_name
in the PR description with the relevant content, wheremarker_name
is one of the following:type
: the PR type.summary
: the PR summary.walkthrough
: the PR walkthrough.Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels
The default labels of the
describe
tool are quite generic: [Bug fix
,Tests
,Enhancement
,Documentation
,Other
].If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:
Main topic:performance
- pr_agent:The main topic of this PR is performanceNew endpoint
- pr_agent:A new endpoint was added in this PRSQL query
- pr_agent:A new SQL query was added in this PRDockerfile changes
- pr_agent:The PR contains changes in the DockerfileThe list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎
For enhanced user experience, the
describe
tool can add file summaries directly to the "Files changed" tab in the PR page.This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).
To enable inline file summary, set
pr_description.inline_file_summary
in the configuration file, possible values are:'table'
: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.true
: A collapsable file comment with changes title and a changes summary for each file in the PR.false
(default): File changes walkthrough will be added only to the "Conversation" tab.Utilizing extra instructions
The
describe
tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.
Examples for extra instructions:
Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands
See the describe usage page for a comprehensive guide on using this tool.
Type
Documentation
Description
Changes walkthrough
endpoint-designer.md
Update Internal Endpoint Middleware Description
tyk-docs/content/advanced-configuration/transform-traffic/endpoint-designer.md
ignore-tyk-classic.md
Add Illustration for Ignore Authentication Middleware
tyk-docs/content/product-stack/tyk-gateway/middleware/ignore-tyk-classic.md
middleware to a Tyk Classic API endpoint.
ignore-tyk-oas.md
Correct Configuration Steps for Ignore Authentication Middleware
tyk-docs/content/product-stack/tyk-gateway/middleware/ignore-tyk-oas.md
internal-endpoint-middleware.md
Introduce Internal Endpoint Middleware Documentation
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-middleware.md
endpoints.
internal-endpoint-tyk-classic.md
Document Using Internal Endpoint Middleware with Tyk Classic APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-classic.md
Classic APIs.
internal-endpoint-tyk-oas.md
Document Using Internal Endpoint Middleware with Tyk OAS APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/internal-endpoint-tyk-oas.md
OAS APIs.
menu.yaml
Update Menu for Internal Endpoint Middleware Documentation
tyk-docs/data/menu.yaml
middleware documentation.