-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DX-993, TT-11639] Updated multiple middleware for OAS #4012
Conversation
PR Analysis
PR Feedback
🤖 Code feedback:
✨ Usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ PS. Pls add /docs/nightly to the end of url
To edit notification comments on pull requests, go to your Netlify site configuration. |
Updated the metadata for Request Header Transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyo-tyk Thanks for submitting the updated middleware content for OAS.
So far I have reviewed
- circuit breakers
- enforced timeouts
- circuit breaker tyk classic APIs
- circuit breaker tyk OAS APIs
- enforced timeout
- enforced timeout Tyk Classic
- request header transformations for tyk classic
I will continue to review the remaining content files tomorrow
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/enforced-timeouts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
@andyo-tyk this is a massive PR :). It's hard to review such a big PR. Going forward, if possible (I appreciate that sometimes it's not), please avoid that. |
Yes - and I've acknowledged and apologised for that in the DX ticket. I'm sorry that on this one occasion I haven't yet added the release version. It's pending peer/technical review so this omission isn't critical. |
Co-authored-by: dcs3spp <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected some copy/paste errors in Request Header OAS page
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR LGTM, have made minor suggestions and made a suggestion of adding a file to content/shared for content shared in summary footer of some pages
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/enforced-timeouts.md
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
…header-tyk-classic.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed H2 Overview titles
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-classic.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/advanced-configuration/transform-traffic/request-method-transform.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/enforced-timeouts.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-classic.md
Outdated
Show resolved
Hide resolved
Co-authored-by: dcs3spp <[email protected]>
PR Description updated to latest commit (de82a73) |
PR Review
Code feedback:
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-oas.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyo-tyk PR LGTM, I have reviewed changes and made small fix suggestions. Once @andrei-tyk has peer approved also, we can merge ready for release.
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
Outdated
Show resolved
Hide resolved
Co-authored-by: andrei-tyk <[email protected]>
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
Outdated
Show resolved
Hide resolved
Co-authored-by: dcs3spp <[email protected]>
User description
Preview Link
https://deploy-preview-4012--tyk-docs.netlify.app/docs/nightly/planning-for-production/ensure-high-availability/circuit-breakers/
https://deploy-preview-4012--tyk-docs.netlify.app/docs/nightly/planning-for-production/ensure-high-availability/enforced-timeouts/
https://deploy-preview-4012--tyk-docs.netlify.app/docs/nightly/advanced-configuration/transform-traffic/request-method-transform/
https://deploy-preview-4012--tyk-docs.netlify.app/docs/nightly/transform-traffic/request-headers/
Description
Updated and improved the docs, adding Tyk OAS, for:
Type
enhancement, documentation
Description
Changes walkthrough
12 files
request-method-transform.md
Enhance Request Method Transform Documentation
tyk-docs/content/advanced-configuration/transform-traffic/request-method-transform.md
middleware's purpose.
configuration examples for both Tyk OAS and Tyk Classic APIs.
circuit-breakers.md
Update Circuit Breakers Documentation with Detailed Overview and
Configuration Examples
tyk-docs/content/planning-for-production/ensure-high-availability/circuit-breakers.md
their purpose and operation.
configuration parameters.
enforced-timeouts.md
Revise Enforced Timeouts Documentation with Operation Details and
Examples
tyk-docs/content/planning-for-production/ensure-high-availability/enforced-timeouts.md
system stability.
operation.
circuit-breaker-tyk-classic.md
New Document on Configuring Circuit Breaker Middleware for Tyk Classic
APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-classic.md
middleware for Tyk Classic APIs.
definition and the Dashboard.
circuit-breaker-tyk-oas.md
New Guide for Circuit Breaker Configuration in Tyk OAS APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/circuit-breaker-tyk-oas.md
in Tyk OAS APIs.
breaker configuration.
enforced-timeout-tyk-classic.md
New Documentation on Enforced Timeout Middleware for Tyk Classic APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-classic.md
Tyk Classic APIs.
definition and the Dashboard.
enforced-timeout-tyk-oas.md
Guide for Configuring Enforced Timeout Middleware in Tyk OAS APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/enforced-timeout-tyk-oas.md
middleware in Tyk OAS APIs.
timeout configuration.
request-header-tyk-classic.md
New Documentation on Request Header Transform Middleware for Tyk
Classic APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-classic.md
Tyk Classic APIs.
header transformation.
request-header-tyk-oas.md
Guide for Request Header Transform Middleware Configuration in Tyk OAS
APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/request-header-tyk-oas.md
APIs.
transformations.
request-method-tyk-classic.md
New Documentation on Configuring Request Method Transform for Tyk
Classic APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-classic.md
middleware in Tyk Classic APIs.
definition and the Dashboard.
request-method-tyk-oas.md
Guide for Request Method Transform Configuration in Tyk OAS APIs
tyk-docs/content/product-stack/tyk-gateway/middleware/request-method-tyk-oas.md
Tyk OAS APIs.
transform configuration.
request-headers.md
Enhance Request Header Transform Documentation
tyk-docs/content/transform-traffic/request-headers.md
middleware's purpose.
configuration examples for both Tyk OAS and Tyk Classic APIs.