Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TwitchLib packages, removed old event overrides from PubSub and Client #68

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

ImCarsen
Copy link
Contributor

Updated all packages to the latest:

  • Costura.Fody -> 5.7.0
  • Serilog.Extensions.Logging -> 3.1.0
  • TwitchLib.Api -> 3.9.0
  • TwitchLib.Client -> 3.3.1
  • TwitchLib.PubSub -> 3.2.6

Mainly updated so I could get Predictions statuses from GetPredictions (which is now GetPredictionsAsync), so nothing new was added, just updated packages and removed any code which was causing errors (things which were removed or changed in TwitchLib, for example RitualNewChatter)

Tested in Unity 2023.1.0b9 and works as expected.

Updated all packages to the latest
Removed any code which was causing errors (things which were removed or changed in TwitchLib e.g. RitualNewChatter)
@Syzuna
Copy link
Member

Syzuna commented Apr 18, 2023

Thanks for that PR.
Do you want to merge that now or wait for Pubsub and Client to be migrated to an updated/rewritten TwitchLib.Communications to fix some reconnection and disconnect issues and then do it with those versions?

@ImCarsen
Copy link
Contributor Author

I guess that depends on two things.

  • If there is not really a timeline for how long that will take, it might be better just to do it now and update again later.
  • If the disconnection issues are not present in the current (d264b1f), and are with these package versions, it might be wise to just make a separate branch for this commit until PubSub and Client are migrated to the updated/rewritten TwitchLib.Communications that you mentioned. Just so it's there if people need the newer functions but don't mind working around possible disconnections.

Either way, if you pull now, whether it be to a separate branch or to master, once the packages update I might as well make another update. (Depends on how major the changes are, I could probably do it if I have the free time)

@swiftyspiffy
Copy link
Member

I'm going to go ahead and merge this, we can make changes on top of this to account for updates from the core library.

@swiftyspiffy swiftyspiffy merged commit 8537f52 into TwitchLib:master Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants