Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cgmath version 0.18 and automatic arcball camera placement #19

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

beltegeuse
Copy link
Contributor

Hi Will,

Please find a pull request that implements two changes:

  1. Bump cgmath to last version (0.18).
  2. Compute AABB from the loaded obj to automatically place the camera for obj_viewer and obj_ao_parallel. This changes the support display struct and adds a new aabb struct.

Best

Copy link
Owner

@Twinklebear Twinklebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beltegeuse , this looks good! Having automatic placement of the camera will be great for the demo apps. I think the only change needed is how the arcball crate is being included.

I've also been (slowly) working on refactoring the codebase a bit to fix the lifetime annoyances, and to also move the viewer to a wgpu-rs based one, since glium is in maintenance mode and I was having some issues with it and related libraries.

examples/support/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Owner

@Twinklebear Twinklebear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beltegeuse , this looks great!

@Twinklebear Twinklebear merged commit 3214a6f into Twinklebear:master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants