Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Mastodon OAuth URL with spaces breaks when using DuckDuckGo as a browser #326

Closed
ObjectBoxPC opened this issue Nov 3, 2021 · 0 comments · Fixed by #367
Closed

[BUG] Mastodon OAuth URL with spaces breaks when using DuckDuckGo as a browser #326

ObjectBoxPC opened this issue Nov 3, 2021 · 0 comments · Fixed by #367
Assignees
@Tlaster @JoeSteven
Labels
bug Something isn't working

Comments

@ObjectBoxPC
Copy link
Contributor

Describe the bug
I am using DuckDuckGo as my default browser, and whenever I try to log in to a Mastodon account, the URL is interpreted as a search query instead of an actual URL to load. I suspect this is due to the spaces in the URL (constructed in the MastodonOAuthService.getWebOAuthUrl function). When I manually adjust the spaces to %20, the URL works as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Install DuckDuckGo Privacy Browser from Google Play Store
  2. Set DuckDuckGo as the default browser app in Settings
  3. Open TwidereX
  4. If TwidereX already has logged-in accounts, go to the "Accounts" menu and click the plus sign. (Otherwise, do nothing as it automatically enters the new-account screen.)
  5. Click "Sign in with Mastodon"
  6. Enter the domain name of a Mastodon instance.
  7. Observe that DuckDuckGo opens to a search page.

Expected behavior
DuckDuckGo should open the OAuth login page for the Mastodon instance.

Screenshots
Hopefully not necessary but I can provide them if needed.

Smartphone (please complete the following information):

  • Device: Samsung Galaxy S9
  • OS: Android 10
  • Google Play Store
  • Twidere 1.5.1

Additional context
N/A
@ObjectBoxPC ObjectBoxPC added the bug Something isn't working label Nov 3, 2021
ObjectBoxPC added a commit to ObjectBoxPC/TwidereX-Android that referenced this issue Dec 13, 2021
@ObjectBoxPC
Use "%20" instead of raw space in Mastodon OAuth URL
2b0f7aa 
This prevents problems with browsers that don't handle URLs with spaces
correctly.

Fixes TwidereProject#326 <TwidereProject#326>
@ObjectBoxPC ObjectBoxPC mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tlaster Tlaster

@JoeSteven JoeSteven

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use "%20" instead of raw space in Mastodon OAuth URL ObjectBoxPC/TwidereX-Android
3 participants
@Tlaster @JoeSteven @ObjectBoxPC