Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerting): Add GitLab alerting provider #485

Merged
merged 9 commits into from
May 31, 2023
Merged

Conversation

hlidotbe
Copy link
Contributor

Summary

This PR adds a new provider for Gitlab alerts (SaaS or self-hosted). It's mostly similar to the github or slack provider with a couple overrides available.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

Copy link
Owner

@TwiN TwiN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Just a small suggestion.

alerting/provider/gitlab/gitlab.go Outdated Show resolved Hide resolved
@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels May 22, 2023
alerting/alert/type.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 78.75% and project coverage change: -0.06 ⚠️

Comparison is base (1dd0ecf) 81.98% compared to head (47f0fba) 81.92%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   81.98%   81.92%   -0.06%     
==========================================
  Files          57       58       +1     
  Lines        4286     4366      +80     
==========================================
+ Hits         3514     3577      +63     
- Misses        602      614      +12     
- Partials      170      175       +5     
Impacted Files Coverage Δ
alerting/provider/provider.go 100.00% <ø> (ø)
alerting/provider/gitlab/gitlab.go 78.48% <78.48%> (ø)
config/config.go 75.00% <100.00%> (+0.10%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

alerting/alert/type.go Outdated Show resolved Hide resolved
alerting/provider/gitlab/gitlab.go Outdated Show resolved Hide resolved
alerting/provider/gitlab/gitlab.go Outdated Show resolved Hide resolved
@TwiN TwiN changed the title Add gitlab alerts provider feat(alerting): Add GitLab alerting provider May 31, 2023
@TwiN TwiN merged commit 7e163c3 into TwiN:master May 31, 2023
@TwiN
Copy link
Owner

TwiN commented May 31, 2023

Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alerting Related to alerting feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants