Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: (baby-project-web) Setup #2

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

WIP: (baby-project-web) Setup #2

wants to merge 24 commits into from

Conversation

AndreasNasman
Copy link
Member

@AndreasNasman AndreasNasman commented Mar 8, 2021

Trying to figure out how to add Stylelint to a Vue project. npx @vue/cli add stylelint adds most of the dependencies and files needed, but it's missing from any lint checking or formatting. Skipping stylelint for now since we're using Tailwind CSS.

@AndreasNasman AndreasNasman self-assigned this Mar 8, 2021
@dusan-turajlic dusan-turajlic linked an issue Mar 29, 2021 that may be closed by this pull request
19 tasks
@AndreasNasman AndreasNasman reopened this Apr 2, 2021
@AndreasNasman AndreasNasman force-pushed the issue-1-Setup branch 3 times, most recently from 267bfc8 to 1a402a0 Compare April 2, 2021 11:26
Copy link
Member

@dusan-turajlic dusan-turajlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good over all had some conserns and questions that might be out of the scope of this PR but felt like they needed to be raised.

src/App.vue Outdated Show resolved Hide resolved
src/components/HelloWorld.vue Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
Copy link
Member

@dusan-turajlic dusan-turajlic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna add a Approval for now, but ping me when everything is ready so I can give it one last look see 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Feature) Setup
2 participants