Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in default acl param #44

Merged
merged 1 commit into from
Sep 22, 2015

Conversation

codemanki
Copy link
Contributor

Hello.

Pretty annoying typo. If you use default settings to upload image, aws will return an error saying:

{
  Code: 'InvalidArgument',
  Message: '',
  ArgumentName: 'x-amz-acl',
  ArgumentValue: 'privat',
  RequestId: '*****',
  HostId: '****' 
}

And just to be 100% sure, here http://docs.aws.amazon.com/AmazonS3/latest/API/RESTObjectPUT.html#rest-object-put-access-permissions privat is not listed as valid value for x-amz-acl:

Valid Values: private | public-read | public-read-write | ....

Hope this helps ;)

@Starefossen
Copy link
Contributor

Thank you for finding and fixing this bug @codemanki 👍

Starefossen added a commit that referenced this pull request Sep 22, 2015
Fix typo in default acl param
@Starefossen Starefossen merged commit a8dcb9c into Turistforeningen:master Sep 22, 2015
@Starefossen
Copy link
Contributor

s3-uploader v1.0.1 have been published to npm with this fix.

@codemanki
Copy link
Contributor Author

@Starefossen thanks ;) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants