Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redundant definition of getstats(t::Any) #2043

Closed
wants to merge 1 commit into from
Closed

Fix redundant definition of getstats(t::Any) #2043

wants to merge 1 commit into from

Conversation

yebai
Copy link
Member

@yebai yebai commented Jul 18, 2023

The getstats(t::Any) is defined twice in the following lines:

Turing.jl/src/inference/Inference.jl

Line 128 in e1d3fef

getstats(t) = nothing

Turing.jl/src/contrib/inference/abstractmcmc.jl

Line 22 in e1d3fef

getstats(transition) = NamedTuple()

@yebai yebai requested a review from JaimeRZP July 18, 2023 11:29
devmotion
devmotion reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC we discussed in #2030 that the definition in abstractmcmc.jl should be removed since it was not consistent with the existing behaviour of setting metadata to nothing?

@devmotion devmotion mentioned this pull request Jul 18, 2023
Merged
@yebai
Copy link
Member Author

yebai commented Jul 18, 2023 •
edited
Loading

Closed in favor of #2044

@yebai yebai closed this Jul 18, 2023
@yebai yebai deleted the yebai-patch-2 branch July 18, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion left review comments

@JaimeRZP JaimeRZP Awaiting requested review from JaimeRZP

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yebai @devmotion