Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #1985

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.32, 0.33 to 0.32, 0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

Closes #1993

@cpfiffer cpfiffer force-pushed the compathelper/new_version/2023-05-02-00-24-45-491-03212618728 branch from a0e8ffb to dad66c6 Compare May 2, 2023 00:24
@github-actions
Copy link
Contributor Author

github-actions bot commented May 2, 2023

Pull Request Test Coverage Report for Build 4856282752

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 4793963451: 0.0%
Covered Lines: 0
Relevant Lines: 1424

💛 - Coveralls

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fb7da8d) 0.00% compared to head (dad66c6) 0.00%.

❗ Current head dad66c6 differs from pull request most recent head 75d0dac. Consider uploading reports for the commit 75d0dac to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1985   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1424    1424           
======================================
  Misses       1424    1424           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yebai
Copy link
Member

yebai commented May 26, 2023

Blocked by JuliaNLSolvers/Optim.jl#1040

@yebai yebai merged commit 861ae37 into master Jun 6, 2023
@yebai yebai deleted the compathelper/new_version/2023-05-02-00-24-45-491-03212618728 branch June 6, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant