Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Libtask.TapedTask #1778

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Switch to Libtask.TapedTask #1778

merged 2 commits into from
Feb 20, 2022

Conversation

rikhuijzer
Copy link
Contributor

In response to TuringLang/Libtask.jl#121 (comment):

Would be good to evaluate if the alias is needed

Turing and AdvancedPS still rely on CTask so it is still needed currently. This PR will move to the new name.

@rikhuijzer rikhuijzer requested a review from devmotion February 20, 2022 07:22
@rikhuijzer rikhuijzer mentioned this pull request Feb 20, 2022
Merged
@devmotion
Copy link
Member

Maybe you can bump the version in the PR?

@rikhuijzer
Copy link
Contributor Author

rikhuijzer commented Feb 20, 2022 •
edited
Loading

I've changed the status to draft so that this PR can be used for integration testing

@rikhuijzer rikhuijzer mentioned this pull request Feb 20, 2022
Merged
@rikhuijzer rikhuijzer marked this pull request as draft February 20, 2022 08:35
devmotion
devmotion reviewed Feb 20, 2022
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
@rikhuijzer rikhuijzer marked this pull request as ready for review February 20, 2022 08:56
@rikhuijzer
Copy link
Contributor Author

Can you merge once CI is done? I don't have rights here

@devmotion
Copy link
Member

Sure, I'll merge when tests pass.

@coveralls
Copy link

coveralls commented Feb 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1871416769

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 81.702%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/essential/container.jl 0 3 0.0%
Totals Coverage Status
Change from base Build 1862261494: 0.01%
Covered Lines: 1219
Relevant Lines: 1492
💛 - Coveralls

@codecov
Copy link

codecov bot commented Feb 20, 2022 •
edited
Loading

Codecov Report

Merging #1778 (c10abfe) into master (9d3be02) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1778      +/-   ##
==========================================
+ Coverage   81.69%   81.70%   +0.01%     
==========================================
  Files          24       24              
  Lines        1491     1492       +1     
==========================================
+ Hits         1218     1219       +1     
  Misses        273      273
Impacted Files Coverage Δ
src/essential/container.jl 79.41% <0.00%> (ø)
src/inference/AdvancedSMC.jl 94.35% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3be02...c10abfe. Read the comment docs.

yebai
yebai reviewed Feb 20, 2022
View reviewed changes
docs/src/using-turing/advanced.md
@@ -191,5 +191,4 @@ model = Turing.Model(modelf, (x = [1.5, 2.0],))

## Task Copying


Turing [copies](https://github.com/JuliaLang/julia/issues/4085) Julia tasks to deliver efficient inference algorithms, but it also provides alternative slower implementation as a fallback. Task copying is enabled by default. Task copying requires us to use the `CTask` facility which is provided by [Libtask](https://github.com/TuringLang/Libtask.jl) to create tasks.
Turing [copies](https://github.com/JuliaLang/julia/issues/4085) Julia tasks to deliver efficient inference algorithms, but it also provides alternative slower implementation as a fallback. Task copying is enabled by default. Task copying requires us to use the `TapedTask` facility which is provided by [Libtask](https://github.com/TuringLang/Libtask.jl) to create tasks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. By the way, soon we can also remove the TArray related docs since the new Libtask can deep-copy heap-allocated objects - we still need to activate it. See https://github.com/TuringLang/Libtask.jl/blob/4a85b47756259c2778c4336c69b7abc0b61a0fb9/src/tapedfunction.jl#L309

@rikhuijzer rikhuijzer mentioned this pull request Feb 20, 2022
Closed
@devmotion devmotion merged commit e07488e into master Feb 20, 2022
@delete-merged-branch delete-merged-branch bot deleted the rh/tapedtask branch February 20, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikhuijzer @devmotion @coveralls @yebai