Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-define ~: macro => function #173

Closed
yebai opened this issue Apr 17, 2017 · 4 comments
Closed

Re-define ~: macro => function #173

yebai opened this issue Apr 17, 2017 · 4 comments
Assignees
@yebai
Milestone
Release 0.3.1

Comments

@yebai
Copy link
Member

yebai commented Apr 17, 2017

Julia 0.6 stopped supporting parsing ~ as a macro by default. We might need to perform this parsing in the model macro on our own and redefine ~ as a function.
@yebai yebai mentioned this issue Apr 21, 2017
Closed
15 tasks
@xukai92 xukai92 mentioned this issue Jun 24, 2017
Closed
@xukai92
Copy link
Member

xukai92 commented Jun 24, 2017

Comments from other developer: syntax sugar like @model and ~ is cool and good for end users but we should also make the plain function available (at least have a section "For Developers" to explain how to use them directly)

@yebai yebai added this to the Release 0.4 milestone Jul 26, 2017
@yebai
Copy link
Member Author

yebai commented Aug 15, 2017

Relevant discussions on this matter:

JuliaLang/julia#4882

JuliaStats/GLM.jl#116

This was referenced Aug 15, 2017
Closed
Merged
@kleinschmidt
Copy link
Contributor

StatsModels.jl handles ~ in a Formula as a function now: see JuliaStats/StatsModels.jl#9

@yebai
Copy link
Member Author

yebai commented Aug 28, 2017

@kleinschmidt Thanks, I'll take a look at that. If you know how to port it to Turing, please get in touch.

@yebai yebai mentioned this issue Aug 28, 2017
Closed
yebai added a commit that referenced this issue Aug 28, 2017
@yebai
Initial support for infix ~ (#173).
219b9f4
@yebai yebai modified the milestones: Release 0.4, Release 0.3.1 Nov 14, 2017
@yebai yebai self-assigned this Nov 14, 2017
yebai added a commit that referenced this issue Nov 16, 2017
@yebai
Solve compatibility with Julia 0.6 (#341, #330, #293)
3f788de 
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
@yebai yebai closed this as completed Nov 16, 2017
emilemathieu pushed a commit that referenced this issue Nov 17, 2017
@yebai @emilemathieu
Solve compatibility with Julia 0.6 (#341, #330, #293)
29e6edf 
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
yebai added a commit that referenced this issue Sep 18, 2018
@yebai
Solve compatibility with Julia 0.6 (#341, #330, #293)
28c9f89 
* Initial support for infix ~ (#173).

* seperate model wrapper call in sample.jl test

* update ForwardDiff.Dual signature

* sample.jl test passed

* fix some tests for Julia 0.6

* remove typealias for 0.6

* make some functions 0.6-ish

* make abstract 0.6-ish

* change some decpreated functions

* Update .travis.yml

* Update appveyor.yml

* Update appveyor.yml

* fix test

* Deprecations on package loading fixed

* fix deprecations

* implement callbacks for inner function

* fix model type bug

* Fix type

* update Dual in benchmark

* update Dual constructor

* Bump up required Julia version to 0.6

* Disable depreciated warning messages for `consume/produce`.

* Remove duplicate definition of produce.

* fix floor, tanh, abs, log

* fix logpdf warning and bug

* fix vec assume init

* Travis: Allow `Benchmarking` test to fail.
@sjwild sjwild mentioned this issue Feb 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yebai yebai

Labels
None yet
Projects
None yet
Milestone
Release 0.3.1
Development

No branches or pull requests
3 participants
@kleinschmidt @yebai @xukai92