Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to add options to not sample observed variables with evaluate!! #253

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

sunxd3
Copy link
Member

@sunxd3 sunxd3 commented Dec 10, 2024

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12260657881

Details

  • 5 of 6 (83.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 71.934%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/model.jl 5 6 83.33%
Totals Coverage Status
Change from base Build 12238991817: 0.006%
Covered Lines: 1402
Relevant Lines: 1949

💛 - Coveralls

Copy link
Contributor

Benchmark results on macOS (aarch64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.5.0 to /Users/runner/.bridgestan/bridgestan-2.5.0
Done!
Model dogs produces error: ErrorException("log_density() failed with unknown exception\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 5.55 8.09733 61.958 299.834
pumps 12 10 0.988071 1.52317 9.63867 21.083
dogs 2 720 NA NA 143.854 383.833
seeds 26 21 2.27083 3.06022 22.834 74.042
surgical_realistic 14 12 1.27841 1.82743 13.0625 32.375
magnesium 108 96 11.521 12.854 124.833 246.5
salm 22 18 3.85714 4.5555 17.833 53.0
equiv 15 20 3.6875 4.70833 16.166 57.458
dyes 9 30 1.68135 2.21525 10.146 44.833
stacks 6 21 1.31944 2.05558 19.917 49.125
epil 303 236 41.583 47.208 214.5 669.083
blockers 47 44 2.75 3.38525 50.458 103.667
oxford 244 240 11.25 13.417 315.0 638.875
lsat 1006 5000 100.833 140.209 1861.29 3325.75
bones 33 422 77.875 89.333 391.542 493.667
mice 20 65 6.70825 8.45833 23.209 94.958
kidney 64 58 8.65267 11.9165 57.875 199.125
leuk 18 714 16.291 21.542 281.917 610.708
leukfr 40 714 22.375 28.792 301.042 796.541

Benchmark results on Ubuntu (x64)

BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.5.0 to /home/runner/.bridgestan/bridgestan-2.5.0
Done!
Model dogs produces error: ErrorException("log_density() failed with exception: Exception: bernoulli_lpmf: Probability parameter is inf, but must be in the interval [0, 1] (in '/home/runner/work/JuliaBUGS.jl/JuliaBUGS.jl/benchmark/stan/bugs_examples/vol1/dogs/dogs.stan', line 37, column 6 to line 38, column 62)\n")

Model Parameter Count Data Count Stan Density Time (µs) Stan Density Gradient Time (µs) JuliaBUGS Density Time with Graph Walk (µs) JuliaBUGS Density Gradient Time with ReverseDiff.jl(compiled tape) (µs)
rats 65 150 5.6006 8.18567 73.748 89.448
pumps 12 10 1.01607 1.42084 12.153 6.49725
dogs 2 720 NA NA 173.801 189.135
seeds 26 21 2.49191 3.26667 27.16 19.726
surgical_realistic 14 12 1.26496 1.70317 15.229 8.52933
magnesium 108 96 10.5395 12.233 128.421 77.455
salm 22 18 2.40617 3.07578 22.452 14.908
equiv 15 20 2.48883 3.51275 19.447 15.429
dyes 9 30 1.02439 1.37638 12.448 13.35
stacks 6 21 1.16971 1.715 23.113 14.898
epil 303 236 33.383 38.632 293.67 236.854
blockers 47 44 3.32363 3.77414 61.996 29.355
oxford 244 240 16.742 19.326 358.332 183.334
lsat 1006 5000 178.905 219.587 1914.08 1156.99
bones 33 422 72.897 90.399 426.179 190.652
mice 20 65 7.27625 9.304 29.615 39.224
kidney 64 58 10.705 16.1 67.396 80.31
leuk 18 714 20.719 27.101 214.322 193.042
leukfr 40 714 23.755 31.89 234.274 279.804

@sunxd3 sunxd3 merged commit 4c5ab1a into master Dec 10, 2024
15 checks passed
@sunxd3 sunxd3 deleted the sunxd/patch_evaluate branch December 10, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants