Improve Collectvariables again

[sunxd3]

Streamline the checks:

• The checking for number of dimensions mismatches is moved to a function called extract_variable_names_and_numdims. This function go through the whole model definition and collect all the variables and their ndims.
• introduced a new function called simplify_lhs, which calls a evaluate function called simple_arithmetic_eval. simple_arithmetic_eval is more restrictive and should only used to evaluate expression in indices and loop bounds.
• use Base.checkbounds to perform in bound checking for data arrays
• introduced new functions to check if the lhs of a deterministic assignment is specified as data

Also used StaticArrays.MVector for array sizes, instead of collecting all possible LHS and do post-processing. This gives better memory performance. On Leuk, the memory use is reduced from ~6MB to ~3MB, mostly should be attributed to this.

Combined, the time is reduce by 1-2 ms.

[github-actions]

Pull Request Test Coverage Report for Build 8078906539

Details

• -35 of 199 (82.41%) changed or added relevant lines in 3 files are covered.
• 30 unchanged lines in 2 files lost coverage.
• Overall coverage decreased (-0.3%) to 79.939%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/utils.jl	97	112	86.61%
src/compiler_pass.jl	65	85	76.47%

Files with Coverage Reduction	New Missed Lines	%
src/utils.jl	14	82.14%
src/compiler_pass.jl	16	90.8%

Totals
Change from base Build 8067597301:	-0.3%
Covered Lines:	1570
Relevant Lines:	1964

---

💛 - Coveralls

[codecov]

Codecov Report

Attention: Patch coverage is 83.83838% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 80.08%. Comparing base (daf6580) to head (066e52b).

Files	Patch %	Lines
src/compiler_pass.jl	77.77%	20 Missing ⚠️
src/utils.jl	88.78%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   80.28%   80.08%   -0.21%     
==========================================
  Files          21       21              
  Lines        1841     1968     +127     
==========================================
+ Hits         1478     1576      +98     
- Misses        363      392      +29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sunxd3]

@yebai can you give this PR a quick pass through?