Backports for 0.28 #694
Merged
Backports for 0.28 #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allow empty subsets of VarInfos * Run JuliaFormatter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix treatment of gid in merge(::Metadata) * Allowing pushing new symbols to TypedVarInfo * Bump patch version to 0.30.1
|
Oh, I guess CI doesn't run on pulls to backport branches. Will have to come back to this tomorrow. |
|
I'm confused as to why CI isn't running, I made it do that in this PR and it did do that here #685 |
|
There we go ... I guess changing the base branch wasn't enough to trigger CI |
Pull Request Test Coverage Report for Build 11389566749Details
💛 - Coveralls |
penelopeysm
approved these changes
Oct 17, 2024
|
Oh, well this is a nice thing to see when you first open your laptop in the morning, thank you @penelopeysm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #692 and #690, make a new patch release 0.28.6.
I haven't actually run the tests locally, just trying my luck at the end of a work day.