Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #537 #538

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Fix for #537 #538

merged 3 commits into from
Sep 19, 2023

Conversation

torfjelde
Copy link
Member

@torfjelde torfjelde commented Sep 19, 2023

Fix for #537

@torfjelde torfjelde requested a review from yebai September 19, 2023 10:18
@coveralls
Copy link

coveralls commented Sep 19, 2023

Pull Request Test Coverage Report for Build 6234259276

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 81.395%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/compiler.jl 6 7 85.71%
Totals Coverage Status
Change from base Build 6128171735: 0.07%
Covered Lines: 2428
Relevant Lines: 2983

💛 - Coveralls

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.07% 🎉

Comparison is base (ffe9272) 81.32% compared to head (259bfd6) 81.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #538      +/-   ##
==========================================
+ Coverage   81.32%   81.39%   +0.07%     
==========================================
  Files          25       25              
  Lines        2982     2983       +1     
==========================================
+ Hits         2425     2428       +3     
+ Misses        557      555       -2     
Files Changed Coverage Δ
src/compiler.jl 93.68% <85.71%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @torfjelde -- it looks good except for the minor comment below.

src/compiler.jl Show resolved Hide resolved
@torfjelde torfjelde enabled auto-merge September 19, 2023 12:23
@torfjelde torfjelde added this pull request to the merge queue Sep 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2023
@yebai yebai added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit 4788480 Sep 19, 2023
12 of 13 checks passed
@yebai yebai deleted the torfjelde/fix-537 branch September 19, 2023 18:11
@yebai yebai mentioned this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants