Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #255 + some other DistributionsAD-stuff #259

Merged
merged 4 commits into from
Jun 3, 2023
Merged

Fix for #255 + some other DistributionsAD-stuff #259

merged 4 commits into from
Jun 3, 2023

Conversation

torfjelde
Copy link
Member

@torfjelde torfjelde commented Jun 3, 2023 •
edited
Loading

Fixes #255 and some other stuff that has gone unnoticed.

devmotion
devmotion approved these changes Jun 3, 2023
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass (I assume they would have caught #255?).

@torfjelde
Copy link
Member Author

Yup! One of the added tests is the case references in the issue:)

@torfjelde torfjelde merged commit 00bf10c into master Jun 3, 2023
@delete-merged-branch delete-merged-branch bot deleted the torfjelde/fix-for-255 branch June 3, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

filldist, up1 not defined
2 participants
@torfjelde @devmotion