Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set @turf/difference to return null with complete overlap #957

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Set @turf/difference to return null with complete overlap #957

merged 2 commits into from
Sep 22, 2017

Conversation

stebogit
Copy link
Collaborator

Ref. #951 (comment)

New output:

var poly = polygon([[[121, -31], [144, -31], [144, -15], [121, -15], [121, -31]]]);
var result = difference(poly, poly);
//= null

@stebogit stebogit self-assigned this Sep 21, 2017
@DenisCarriere
Copy link
Member

Woot! 🎉

var result = difference(poly, poly) || 'foobar';
//='foobar'

DenisCarriere
DenisCarriere approved these changes Sep 22, 2017
View reviewed changes
Copy link
Member

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DenisCarriere DenisCarriere merged commit 21b6363 into master Sep 22, 2017
@DenisCarriere DenisCarriere deleted the difference-null branch September 22, 2017 03:02
@DenisCarriere DenisCarriere added this to the 4.8.0 milestone Sep 22, 2017
@DenisCarriere DenisCarriere modified the milestones: 4.8.0, 5.0.0 Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisCarriere DenisCarriere DenisCarriere approved these changes

Assignees

@stebogit stebogit

Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@stebogit @DenisCarriere