Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds @turf/boolean-equal test #883

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Adds @turf/boolean-equal test #883

merged 1 commit into from
Aug 2, 2017

Conversation

stebogit
Copy link
Collaborator

@stebogit stebogit commented Aug 2, 2017

@rowanwins following this your note I added the test for Polygons with different initial vertices and apparently it works fine 🤔
Am I doing it properly?

@stebogit stebogit self-assigned this Aug 2, 2017
@stebogit stebogit requested a review from rowanwins August 2, 2017 15:35
@DenisCarriere
Copy link
Member

👍 Looks fine to me, seems like GeoJSON Equality handles this correctly.

@stebogit
Copy link
Collaborator Author

stebogit commented Aug 2, 2017

@DenisCarriere should we add this to the v.4.6 release?
Not sure what the procedure is to officially release the release 😄

@DenisCarriere
Copy link
Member

DenisCarriere commented Aug 2, 2017

👍 Sure! We can add it to the v4.6 since I haven't "officially" published anything, going to publish the TurfJS release when we finish that draft... so anything you want to squeeze in before I publish can go into this release.

@DenisCarriere DenisCarriere added this to the 4.6.0 milestone Aug 2, 2017
@DenisCarriere DenisCarriere merged commit cabd4e7 into master Aug 2, 2017
@rowanwins
Copy link
Member

Awesome, glad you didn't have to change a thing :)

@DenisCarriere DenisCarriere deleted the equal-test branch August 3, 2017 03:51
@stebogit
Copy link
Collaborator Author

stebogit commented Aug 3, 2017

Me too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants