Support GeometryCollection in @turf/line-chunk. #726
Conversation
|
|
||
| /** | ||
| * Divides a {@link LineString} into chunks of a specified length. | ||
| * If the line is shorter than the segment length then the original line is returned. | ||
| * | ||
| * @name lineChunk | ||
| * @param {FeatureCollection|Feature<LineString|MultiLineString>} featureIn the lines to split | ||
| * @param {FeatureCollection|Feature|GeometryCollection<LineString|MultiLineString>} featureIn the lines to split |
There was a problem hiding this comment.
For the JSDocs I've been using Geometry to encompass all Geometry Collection & Geometry Objects.
There was a problem hiding this comment.
You're right. A GeometryCollection is a Geometry per the spec. In my head I think of them as different since it's strange to think of a collection of something to also be that something, but it is.
There was a problem hiding this comment.
I've never really understood the difference between both of them until you've pointed it out to me. Geometry Collections is hard one to support, however with the latest flattenEach method it's pretty simple now.
+1
| feature.geometry.coordinates = feature.geometry.coordinates.reverse(); | ||
| var lineSegments = sliceLineSegments(feature, segmentLength, units); | ||
| lineSegments.forEach(function (segment, index) { | ||
| if (debug === true) { |
There was a problem hiding this comment.
Didn't notice (debug===true) was still here, this section can be removed since it can easily be handled in the test.js.
| // Flatten each feature to simple LineString | ||
| flattenEach(featureIn, function (feature) { | ||
| if (reverse) { | ||
| feature.geometry.coordinates = feature.geometry.coordinates.reverse(); |
There was a problem hiding this comment.
I wonder if this would cause the input geojson to be mutated, I'll add a test case for that and see if this method causes input mutation.
|
@dpmcmlxxvi Next time can you create your branches in TurfJS, doesn't seem like I can push commits to this PR. I'll merge this PR and add my commits afterwards. |
- Dropped colorized source code, placed in testing instead. - Update Typescript definition to support Geometry Objects - Udpate Benchmark results - Improve tests to catch Geometry Objects & Input Mutation - Update authors - Add reverse to typescript definition Ref: #726 CC: @dpmcmlxxvi
|
Will do. |
|
Added to this PR:
|
Addresses #710 for
line-chunkto add GeometryCollection support. Updates include:featureEach/flattenwithflattenEach.Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.