First pass at adding redone maps #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisCarriere
approved these changes
Apr 12, 2017
| * //=polygon | ||
| * //addToMap | ||
| * polygon.properties.area = area | ||
| * var addToMap = [polygon] |
There was a problem hiding this comment.
🏅 Nicely done! Adding the results in the properties 👍
| * | ||
| * //=bbox | ||
| * | ||
| * //=bboxPolygon |
There was a problem hiding this comment.
Agreed, we can remove these comments if //addToMap is present.
| * "geometry": { | ||
| * "type": "Point", | ||
| * "coordinates": [-75.343, 39.984] | ||
| * } | ||
| * }; | ||
| * var point2 = { | ||
| * "type": "Feature", | ||
| * "properties": { | ||
| * "marker-color": '#0f0' |
There was a problem hiding this comment.
👍 Removing the any extra properties.
|
@rowanwins 👍 Looks great! |
|
@rowanwins Delete the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gday @DenisCarriere
Starting the process of re-adding the maps. I've tested these modules locally and they are working well.
The only one which presents a bit funny is
bbox-clipwhich needs a bit of love on the styling to get it to present well but im having a think about that.Just thought I'd share these in case another other red flags jump about before i do the others...