Resolved conversion bugs and updated tests #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anotherhale
commented
Feb 25, 2021
| @@ -519,10 +519,13 @@ test("round", (t) => { | |||
|
|
|||
| test("convertLength", (t) => { | |||
| t.equal(convertLength(1000, "meters"), 1); | |||
| t.equal(convertLength(1000, "meters", "kilometers"), 1); | |||
There was a problem hiding this comment.
Added this one just for completeness
|
@ALL This is a very easy PR to review. I don't have a ticket filed for the original conversion bug - I can open one for it if you like. |
This was referenced Jun 7, 2021
Closed
This was referenced Jun 17, 2021
4 tasks
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm testat the sub modules where changes have occurred.npm run lintto ensure code style at the turf module level.This resolves the Meter/Yard and Yard/Meter conversion ratios and also updates the tests to validate the conversions work appropriately.