Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't revisit wrapping coordinate when calculating centroid #1894

Merged
merged 4 commits into from
May 7, 2020

Conversation

rowanwins
Copy link
Member

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Don't revisit the wrapping coord when calculating the centroid. Also updated the coordEach definition.

Resolves #1539

@rowanwins rowanwins requested a review from mfedderly May 3, 2020 06:33
Copy link
Collaborator

@mfedderly mfedderly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rich diff on the tests winds up with small changes that appear to be better centering.

@rowanwins rowanwins merged commit 3fa082c into master May 7, 2020
@rowanwins rowanwins deleted the centroid-fix branch May 7, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong centroid calculation
2 participants