Fix version inconsistencies #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of the package.json files were referencing @turf/* dependencies at a different version than is available in the repo. When this happens, yarn will download an extra copy of that package, instead of using the one in the local repo, which can cause issues.
This version uses 'const', but at least it fixed the bug where diff wasn't even an export
Looks like @turf/union changed in a few ways - it only takes 2 geojsons instead of an arbitrary number - it can return a multipolygon instead of just a single polygon This changes the output of a bunch of tests in a way that I'm not super comfortable with
Now we can get a MultiPolygon back so the checks for having the same type are a little wonky I updated the check here because the logic below looks like it handles more things than the check allowed through
geojson-rbush depends on @turf/bbox but isn't in the turfjs/turf repo. This is a precarious setup especially with the '*' dependency in geojson-rbush. This makes me sad on two fronts: - export default from typescript modules is different between JS and ES builds - I'm not sure whether or not we should even use default exports from each of the modules, which is a breaking change - Maybe all of our default exports should have the extra nested default hack
…the way that it was
|
Filed #1866 to track updating martinez-polygon-clipping and fixing the tests for real instead of skipping them. |
|
@rowanwins this is ready for you |
rowanwins
approved these changes
Mar 21, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a bunch of issues today when moving more fully into ES module territory. In order to fix some of them I decided to synchronize all of the package versions. I was hoping to wait for a release to do this, but there were actually API breaks so we need to fix this before we can release.
Check the individual commits for more details on the issues I ran into.