Resolve #1539 where incorrect centroid is calculated for polygon

Turfjs · Dec 4, 2018 · 2a64511 · 2a64511
1 parent fd08414
commit 2a64511
Show file tree

Hide file tree

Showing 5 changed files with 62 additions and 5 deletions.
diff --git a/src/centroid/index.js b/src/centroid/index.js
@@ -27,7 +27,7 @@ function centroid(geojson, options) {
         xSum += coord[0];
         ySum += coord[1];
         len++;
-    });
+    }, true);
     return point([xSum / len, ySum / len], options.properties);
 }
 

diff --git a/src/centroid/test/in/polygon2.geojson b/src/centroid/test/in/polygon2.geojson
@@ -0,0 +1,8 @@
+{
+ "type": "Feature",
+  "properties": {},
+  "geometry": {
+    "type": "Polygon",
+    "coordinates": [[[-1, -1], [1, -1], [1, 1], [-1, 1], [-1, -1]]]
+  }
+}
diff --git a/src/centroid/test/out/imbalanced-polygon.geojson b/src/centroid/test/out/imbalanced-polygon.geojson
@@ -9,8 +9,8 @@
 			"geometry": {
 				"type": "Point",
 				"coordinates": [
-					4.851914405822754,
-					45.78098812633097
+					4.851791984156558,
+					45.78143055383553
 				]
 			}
 		},

diff --git a/src/centroid/test/out/polygon.geojson b/src/centroid/test/out/polygon.geojson
@@ -9,8 +9,8 @@
 			"geometry": {
 				"type": "Point",
 				"coordinates": [
-					4.839177131652832,
-					45.76256007199914
+					4.841194152832031,
+					45.75807143030368
 				]
 			}
 		},

diff --git a/src/centroid/test/out/polygon2.geojson b/src/centroid/test/out/polygon2.geojson
@@ -0,0 +1,49 @@
+{
+	"type": "FeatureCollection",
+	"features": [
+		{
+			"type": "Feature",
+			"properties": {
+				"marker-symbol": "circle"
+			},
+			"geometry": {
+				"type": "Point",
+				"coordinates": [
+					0,
+					0
+				]
+			}
+		},
+		{
+			"type": "Feature",
+			"properties": {},
+			"geometry": {
+				"type": "Polygon",
+				"coordinates": [
+					[
+						[
+							-1,
+							-1
+						],
+						[
+							1,
+							-1
+						],
+						[
+							1,
+							1
+						],
+						[
+							-1,
+							1
+						],
+						[
+							-1,
+							-1
+						]
+					]
+				]
+			}
+		}
+	]
+}