Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trig functions not marked NaN-able even though they return NaN at Infinity or -Infinity #102

Closed
Tacodiva opened this issue Dec 7, 2022 · 0 comments · Fixed by #105
Closed

Trig functions not marked NaN-able even though they return NaN at Infinity or -Infinity #102

Tacodiva opened this issue Dec 7, 2022 · 0 comments · Fixed by #105

Comments

@Tacodiva
Copy link

Tacodiva commented Dec 7, 2022 •
edited
Loading

This block:

image

returns NaN in TurboWarp but 0 in Scratch, because sin, cos and tan return can NaN when their input is Infinity or -Infinity, but are not marked as able to be NaN.

See demo project 773375319 on Scratch and TurboWarp.
@Tacodiva Tacodiva changed the title Trig functions not marked NaN-able when they return nan at Infinity or -Infinity Trig functions not marked NaN-able even though they return NaN at Infinity or -Infinity Dec 7, 2022
@GarboMuffin GarboMuffin mentioned this issue Dec 8, 2022
Merged
Tacodiva added a commit to Tacodiva/turbowarp-vm that referenced this issue Dec 19, 2022
@Tacodiva
Fix TurboWarp#102 and TurboWarp#103
8e91346
Tacodiva added a commit to Tacodiva/turbowarp-vm that referenced this issue Jan 27, 2024
@Tacodiva
Fix TurboWarp#102 and TurboWarp#103
64fd85d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

js: Mark sin, cos, tan, and random as NaN-able TurboWarp/scratch-vm
1 participant
@Tacodiva