Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamejolt: various updates #934

Merged
merged 9 commits into from
Aug 25, 2023
Merged

Conversation

softedco
Copy link
Contributor

  • Promisified the requesting blocks except the ones that would become slow to extract all data from
    (Planning to promisify all of them in the future and then add blocks that return everything in .json as an alternative)
  • Made error messages more accurate and consistent
  • Replaced indents with labels (Didn't check if that breaks compatibility)
  • Some cosmetic changes in the code, also removed eslint disabling, let's see how it goes

extensions/gamejolt.js Outdated Show resolved Hide resolved
@GarboMuffin
Copy link
Member

The remaining errors from ESLint are actual errors

Missed those 2, should pass the checks now
@softedco
Copy link
Contributor Author

So I fixed the errors but it somehow broke the formatting again

@GarboMuffin
Copy link
Member

do not worry about the formatting

@softedco
Copy link
Contributor Author

do not worry about the formatting

Ok

@GarboMuffin
Copy link
Member

@LilyMakesThings @David-Orangemoon at least one of you uses this extension, can you test this out?

@LilyMakesThings
Copy link
Contributor

@LilyMakesThings @David-Orangemoon at least one of you uses this extension, can you test this out?

What needs testing specifically?

@GarboMuffin GarboMuffin changed the title Game Jolt API Extension Update gamejolt: various updates Aug 25, 2023
@GarboMuffin
Copy link
Member

I don't have a way to test this, perhaps you might be able to just give it a 30 second check to see if basic functionality at least still works

or not and I'll just merge this like tomorrow or so

@LilyMakesThings
Copy link
Contributor

I will test it now

@LilyMakesThings
Copy link
Contributor

LilyMakesThings commented Aug 25, 2023

Session + Login worked fine (it works)
image

@GarboMuffin
Copy link
Member

I suppose we'll just see what breaks!

@GarboMuffin GarboMuffin merged commit b2451f0 into TurboWarp:master Aug 25, 2023
3 checks passed
@softedco softedco deleted the softedco-patch-1 branch October 9, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants