Asset Manager: Add "Asset Manager" extension. #891
Conversation
|
Let's gooooo! |
|
simple anti-cheat? |
|
please add this in 10 minutes |
extensions/Lily/Assets.js
Outdated
| @@ -0,0 +1,630 @@ | |||
| // Name: Asset Manager | |||
| // ID: lmsAssets | |||
| // Description: Add, remove, and get data from sprites, costumes and sounds. | |||
There was a problem hiding this comment.
Minor nitpick, but the oxford commas in the description are inconsistent.
There was a problem hiding this comment.
damn you're right
extensions/Lily/Assets.js
Outdated
| spriteNames.push({ | ||
| text: targetName, | ||
| // We, rather unfortunately, have to rely on Target IDs. This is a terrible idea. | ||
| value: targetId, |
There was a problem hiding this comment.
what reason?
pretty sure those are entirely randomly generated each page load
There was a problem hiding this comment.
They do, that's a very good point. The problem comes from one of the blocks allowing you to rename a sprite. If the sprite changes names, then the block would suddenly not work so long as it used just the sprite's name.
There was a problem hiding this comment.
It's the same problem as List Tools, except here it's much more dire because one of the blocks from the extension can literally break itself if it used names as opposed to IDs
|
i don't know why this was stalled anymore so it probably wasn't important |
Extension dedicated solely to editing assets within the project, with some similar blocks on the side.
I received explicit permission from TheShovel to make and pull request this, and we both agreed it would be better to have this as a separate extension from ShovelUtils. (Also much easier than to merge this with ShovelUtils).
Feedback is appreciated.