Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added websocket extension #826

Merged
merged 41 commits into from
Nov 5, 2023
Merged

added websocket extension #826

merged 41 commits into from
Nov 5, 2023

Conversation

RedMan13
Copy link
Contributor

@RedMan13 RedMan13 commented Aug 1, 2023

No description provided.

@RedMan13
Copy link
Contributor Author

RedMan13 commented Aug 1, 2023

to be clear this is just to get rid of the junk commits inside of the original pr

@GarboMuffin
Copy link
Member

they all get squashed down anyways but ok

@RedMan13
Copy link
Contributor Author

they all get squashed down anyways but ok

oh.

@GarboMuffin
Copy link
Member

GarboMuffin commented Aug 27, 2023

This throws an error:

image

image

You can argue I'm using it wrong (which I would consider poor block design), but regardless it must never be throwing errors

@GarboMuffin
Copy link
Member

GarboMuffin commented Aug 27, 2023

I would also love to see some attempt to make it so that multiple messages received between frames are all given an opportunity to be processed, not just silently ignored

@RedMan13
Copy link
Contributor Author

This throws an error:

image

image

You can argue I'm using it wrong (which I would consider poor block design), but regardless it must never be throwing errors

fair on the errors
should i make it so that the send block waits on the connect event for the script then?

@GarboMuffin
Copy link
Member

GarboMuffin commented Aug 27, 2023

should i make it so that the send block waits on the connect event for the script then?

yeah probably

@RedMan13
Copy link
Contributor Author

should i make it so that the send block waits on the connect event for the script then?

yeah probably

kk

@RedMan13
Copy link
Contributor Author

RedMan13 commented Oct 9, 2023

dead chat :trollface:

@GarboMuffin
Copy link
Member

not dead!

@RedMan13
Copy link
Contributor Author

RedMan13 commented Oct 9, 2023

not dead!

image

@GarboMuffin
Copy link
Member

if you have no complaints about the rewrite I'll merge it this week

@RedMan13
Copy link
Contributor Author

RedMan13 commented Nov 3, 2023

if you have no complaints about the rewrite I'll merge it this week

alr

@RedMan13
Copy link
Contributor Author

RedMan13 commented Nov 3, 2023

yeah i see nothing wrong

@GarboMuffin GarboMuffin merged commit ef52775 into TurboWarp:master Nov 5, 2023
3 checks passed
@RedMan13
Copy link
Contributor Author

RedMan13 commented Jan 3, 2024

a

@TurboWarp TurboWarp locked as spam and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants