Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Input Extension #818

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Conversation

SharkPool-SP
Copy link
Collaborator

@SharkPool-SP SharkPool-SP commented Jul 31, 2023

VERSION 4.0!!
Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better.
image

Screenshot 2023-10-09 at 9 04 42 PM

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block.
@qxsck
Copy link
Contributor

qxsck commented Jul 31, 2023

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

@SharkPool-SP
Copy link
Collaborator Author

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

Doesn’t really matter. If there’s no response it will return empty; just like the current ask and wait block

@LilyMakesThings
Copy link
Contributor

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

Doesn’t really matter. If there’s no response it will return empty; just like the current ask and wait block

It does matter, actually. For parity with the actual ask block, you should return an empty string.

@SharkPool-SP
Copy link
Collaborator Author

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

Doesn’t really matter. If there’s no response it will return empty; just like the current ask and wait block

It does matter, actually. For parity with the actual ask block, you should return an empty string.

No that’s what I mean, it will return an empty string when there’s no input

@LilyMakesThings
Copy link
Contributor

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

Doesn’t really matter. If there’s no response it will return empty; just like the current ask and wait block

It does matter, actually. For parity with the actual ask block, you should return an empty string.

No that’s what I mean, it will return an empty string when there’s no input

It should also do that when it's cancelled. Make a boolean that is toggled when an input is cancelled or not.

@SharkPool-SP
Copy link
Collaborator Author

Adds various blocks for custom CSS inputs. Focused on remodeling the ask () block to be better. Screen Shot 2023-07-30 at 11 49 39 PM

Should UserInput return null instead of 'canceled' without input?

Doesn’t really matter. If there’s no response it will return empty; just like the current ask and wait block

It does matter, actually. For parity with the actual ask block, you should return an empty string.

No that’s what I mean, it will return an empty string when there’s no input

It should also do that when it's cancelled. Make a boolean that is toggled when an input is cancelled or not.

I might add the Boolean for that in a later update. I like the cancel button the way it is thought since the button makes the input report cancelled. That way people can use better input as a button selection thing rather than an input and press OK. That’s also why the Input and cancel button has an option to be enabled or disabled.

@SharkPool-SP
Copy link
Collaborator Author

Extension was updated. Merged some blocks, changed some names and functions, added the ability to enable/disable 2 more buttons and fixed some bugs.

@SaFireGalaxy
Copy link

Hey sharkpool? Can you possibly make it so you can force-submit the input? This would be handy for having the "enter" key be another option to submit your inputs.

@yuri-kiss
Copy link
Contributor

Hey sharkpool? Can you possibly make it so you can force-submit the input? This would be handy for having the "enter" key be another option to submit your inputs.

its ask and wait which means it should wait, and force submitting the input without the users permission could be annoying due to it having the off chance to force submit a unfinished sentence word, or anything that was typed, i say this because it could be multi-line. if possible it should just be "shift-enter" to submit, or like in the console set it to "enter" and to add a new line set it to "shift-enter"

@SaFireGalaxy
Copy link

That's a good suggestion. Maybe also, Shift enter could create a new line and enter could submit it. It will act as the submit button, but not a replacement of it.

@SharkPool-SP
Copy link
Collaborator Author

That's a good suggestion. Maybe also, Shift enter could create a new line and enter could submit it. It will act as the submit button, but not a replacement of it.

Hi, so I read the past couple comments. I’ll consider the shift enter thing. I’ll either add it or add a block that allows/doesn’t allow enter to submit.

@SaFireGalaxy
Copy link

Thanks so much! This beats the ask and wait block in every possible way now, I won't have to use that block anymore.

@SharkPool-SP
Copy link
Collaborator Author

Thanks so much! This beats the ask and wait block in every possible way now, I won't have to use that block anymore.

Thanks :)

@SharkPool-SP SharkPool-SP reopened this Aug 4, 2023
@SharkPool-SP
Copy link
Collaborator Author

Thanks so much! This beats the ask and wait block in every possible way now, I won't have to use that block anymore.

Updated! Added that block and some more 👀

Copy link
Member

@GarboMuffin GarboMuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left some comments

extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
extensions/SharkPool/BetterInput.js Outdated Show resolved Hide resolved
@SharkPool-SP
Copy link
Collaborator Author

Thanks so much! This beats the ask and wait block in every possible way now, I won't have to use that block anymore.

Thanks!!! Updates coming soon :)))

Fixes n' new stuff
@SharkPool-SP
Copy link
Collaborator Author

Fixed all issues and added new stuff!
Screen Shot 2023-08-18 at 11 56 56 PM

shut up eslint
@SharkPool-SP
Copy link
Collaborator Author

image
Another Update

@ghost
Copy link

ghost commented Dec 20, 2023

That #1029 issue wasn't a real issue. It was me complaining...

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants