Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sorting blocks to JSON. #723

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Add sorting blocks to JSON. #723

merged 5 commits into from
Aug 25, 2023

Conversation

yuri-kiss
Copy link
Contributor

Blocks added:
image

image
allows you to sort some numbers in ascending or descending order using a algorithm in the dropdown[f1]

image
allows you to sort letters / words in ascending or descending order.

Sorting option for numbers [f1]:
image

image

Difference from list utils version:
(video from @LilyMakesThings)
https://github.com/TurboWarp/extensions/assets/135030944/bf13697f-d459-4b25-8d34-2b4b3822a7dd

@BlueDome77
Copy link
Contributor

Awesome! (づ>◞ <)づ

@Skyhigh173
Copy link
Contributor

great! however there's two JSON extension poll about sorting.

@yuri-kiss
Copy link
Contributor Author

great! however there's two JSON extension poll about sorting.

yes, I made mine 18hrs before the otherone, but lily wanted the other person to also make a pr.
Its fine.

@GarboMuffin
Copy link
Member

I don't think having all those sorting algorithms is necessary

@GarboMuffin
Copy link
Member

if it was just sort ascending/descending I would merge this right now

@yuri-kiss
Copy link
Contributor Author

I don't think having all those sorting algorithms is necessary

well lily is already doing ascending + descending in her list extension so it would be as simple as setting the list to the json and then running the sort you want and then just grabbing it, its like 4 blocks

@GarboMuffin
Copy link
Member

GarboMuffin commented Aug 23, 2023

These still have a place in JSON without using an intermediate list variable

Ignore all the merge conflicts and don't bother merging master, I will do that later, if you finish this extension

@yuri-kiss
Copy link
Contributor Author

These still have a place in JSON without using an intermediate list variable

Ignore all the merge conflicts and don't bother merging master, I will do that later, if you finish this extension

would you like me to just comment out the other stuff or fully remove it?

@GarboMuffin
Copy link
Member

Minified sorting algorithms are unlikely to be useful as comments

@yuri-kiss
Copy link
Contributor Author

ok i will update it :D

removed all the sorting algorithms :(
@yuri-kiss
Copy link
Contributor Author

doneeeeeeeeeeeee

@GarboMuffin GarboMuffin merged commit b0f8c20 into TurboWarp:master Aug 25, 2023
3 checks passed
@yuri-kiss
Copy link
Contributor Author

woohooo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants