Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NG: Cast medalID inputs for medal arguments #1733

Merged
merged 2 commits into from
Oct 23, 2024
Merged

NG: Cast medalID inputs for medal arguments #1733

merged 2 commits into from
Oct 23, 2024

Conversation

JeremyGamer13
Copy link
Contributor

This can cause weird issues where the medal ID is a string and therefore technically does not exist:
image

This also fixes the input type from STRING to NUMBER since the other block for medals uses NUMBER as well.

RedMan13
RedMan13 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@RedMan13 RedMan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :good:

@GarboMuffin GarboMuffin merged commit 63377ee into TurboWarp:master Oct 23, 2024
3 checks passed
@LSPECTRONIZTAR
Copy link

LET'S GO IT GOT MERGED

@GarboMuffin GarboMuffin added the pr: change existing extension Pull requests that change an existing extension label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CubesterYT CubesterYT CubesterYT approved these changes

@RedMan13 RedMan13 RedMan13 approved these changes

@GarboMuffin GarboMuffin GarboMuffin approved these changes

Assignees
No one assigned
Labels
pr: change existing extension Pull requests that change an existing extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeremyGamer13 @LSPECTRONIZTAR @GarboMuffin @RedMan13 @CubesterYT