Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image update batch #1518

Merged
merged 16 commits into from
Jun 9, 2024
Merged

Image update batch #1518

merged 16 commits into from
Jun 9, 2024

Conversation

GarboMuffin
Copy link
Member

About 8 months late

Various things from #90 and #1079

@GarboMuffin GarboMuffin merged commit e1b9fd9 into master Jun 9, 2024
3 checks passed
@GarboMuffin GarboMuffin deleted the images branch June 9, 2024 07:40
@SharkPool-SP
Copy link
Collaborator

Im gonna miss the old fetch

@SharkPool-SP
Copy link
Collaborator

SharkPool-SP commented Jun 9, 2024

also you forgot about key simulation, sent in the discord months ago

@GarboMuffin
Copy link
Member Author

@veggiecan0419 instead of just thumbs down reacting, can you elaborate which images you think are worse?

@veggiecan0419
Copy link
Contributor

@GarboMuffin Actually, I preffered how most of them were before.

With sensing+, I feel the old image better represented the extension (as it isn't only touch blocks).
As for fetch, I liked the old concept (the dog fetching the bone).

As for browser fullscreen, I do have to admit it was a 30min job, but I don't think it looked that bad, just the colours were a bit dull (and it wasn't SVG).

The only ones I really feel got an improvement were deltatime and all menus.

As for all the others, I think that they were good, because they gave the gallery a diverse feel, which I quite liked (I feel now it looks pretty monotone and repetitive).

@GarboMuffin
Copy link
Member Author

Thank you for elaborating

Let me explain the motivation for why those images were due to get changed:

  • Many contained the name of the extension. This is redundant and can't be translated.
  • The old sensing+ has trademarks that we definitely should not be using in that context (griffpatch has gotten letters about his use of the Scratch Cat).
  • SVG is easier for other people to edit and looks better. Usually smaller too (old browser fullscreen 58KB, new 3KB)
  • There is a general style that the images should try to follow, but there is still plenty of room for the images to look unique within that style.
  • 2 of the extensions didn't even have images before

If you have better versions that don't regress the problems above, you can submit them and they will get looked at in less than 8 months this time

@GarboMuffin
Copy link
Member Author

GarboMuffin commented Jun 9, 2024

Any change that wasn't one of those bullet points, like the dog fetching metaphor being replaced, was largely coincidental and can be reverted if someone submits a better one. None of the images are final

@veggiecan0419
Copy link
Contributor

@GarboMuffin 👍

@xTvii
Copy link

xTvii commented Jul 8, 2024

Sorry if some of the ones I submitted were a bit of a downgrade !!! ( I made the new fetch and sensing + ones . I also made quite some more if you check #1079 . I'm going to try and make some more too !!! I hope they're better !!

@xTvii
Copy link

xTvii commented Jul 13, 2024

HHOYAH ! i present to you , garbo , my latest invention !!! THE #1607 INATOR THREE THOUSAND !!! YYAAAAAYA more icons is always a good thing especially when like 4 million ( at least 3 of them ) of them have text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants