-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add network and network-m extensions #122
Conversation
I believe most of the blocks won't be added because:
|
I have temporarily deleted ping block. In the future, I want to refine it a lot. |
It seems that the extension is ready for publication. I hope there are no mistakes in it. |
Sorry for all the massive delays on this I question whether it is necessary to name it See the one review comment above and I'll merge it |
you could consider changing the ID of the extensions internally as |
Sorry for the delay, I didn't answer due to my health condition. |
Yes, i agree |
I propose to leave the versions, but reduce the spelling to |
Extension contains a lot of blocks for working with the network:
network
is now more global, so combine it withfetch
would be wrong. Please add it separately.PS: I tried to add all the suggestions here, if I missed something or misunderstood, please write.
PPS: I think it would be good to leave the ping block, because adding it as a separate extension is not very convenient.
PPPS: Thanks @softedco for optimizing the code