Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network and network-m extensions #122

Merged
merged 8 commits into from
Feb 4, 2023
Merged

Add network and network-m extensions #122

merged 8 commits into from
Feb 4, 2023

Conversation

True-Fantom
Copy link
Contributor

@True-Fantom True-Fantom commented Jan 8, 2023

network banner

Extension contains a lot of blocks for working with the network:

Screenshot_192

network is now more global, so combine it with fetch would be wrong. Please add it separately.

PS: I tried to add all the suggestions here, if I missed something or misunderstood, please write.

PPS: I think it would be good to leave the ping block, because adding it as a separate extension is not very convenient.

PPPS: Thanks @softedco for optimizing the code

@softedco
Copy link
Contributor

softedco commented Jan 9, 2023

I believe most of the blocks won't be added because:

  • Server pinging extension already exists
  • Fetch related blocks can be moved to the fetch extension
  • Open window blocks can be replaced with special behaviour cloud variables and also they can be used mauliciously but I'm not sure if that's the case

@True-Fantom True-Fantom changed the title Add network extension 2.0 Add network extension 3.0 and network-m extension Jan 23, 2023
@True-Fantom
Copy link
Contributor Author

I have temporarily deleted ping block. In the future, I want to refine it a lot.

@True-Fantom
Copy link
Contributor Author

It seems that the extension is ready for publication. I hope there are no mistakes in it.

@True-Fantom True-Fantom changed the title Add network extension 3.0 and network-m extension Add network and network-m extensions Jan 23, 2023
@GarboMuffin
Copy link
Member

GarboMuffin commented Jan 26, 2023

Sorry for all the massive delays on this

I question whether it is necessary to name it network-m/network-m-v001.js. That's a bit of a mouthful and largely redundant, but okay, this is your namespace, do as you please

See the one review comment above and I'll merge it

@GarboMuffin
Copy link
Member

you could consider changing the ID of the extensions internally as network is vague and sort of defeats the purpose of the username-specific folders

@GarboMuffin GarboMuffin merged commit d979af4 into TurboWarp:master Feb 4, 2023
@True-Fantom
Copy link
Contributor Author

Sorry for the delay, I didn't answer due to my health condition.

@True-Fantom
Copy link
Contributor Author

you could consider changing the ID of the extensions internally as network is vague and sort of defeats the purpose of the username-specific folders

Yes, i agree

@True-Fantom
Copy link
Contributor Author

True-Fantom commented Feb 5, 2023

Sorry for all the massive delays on this

I question whether it is necessary to name it network-m/network-m-v001.js. That's a bit of a mouthful and largely redundant, but okay, this is your namespace, do as you please

See the one review comment above and I'll merge it

I propose to leave the versions, but reduce the spelling to network/network-01.js and network/network-m01.js

@True-Fantom
Copy link
Contributor Author

True-Fantom commented Feb 5, 2023

And I also think that these blocks
Screenshot_195
go beyond the network, so can I move them to the window.js?
With additional blocks in this topic of course.
Screenshot_196

@GarboMuffin
Copy link
Member

Feel free to submit whatever extensions to your user folder that you see fit

I assume you are okay with having your name and Scratch profile listed like this?

image

@True-Fantom
Copy link
Contributor Author

Feel free to submit whatever extensions to your user folder that you see fit

I assume you are okay with having your name and Scratch profile listed like this?

image

Yes, I'm all for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants