Updated compatibility info

[elleryalvarez]

No description provided.

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (637a033) 90.19% compared to head (f1a9436) 90.23%.
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   90.19%   90.23%   +0.03%     
==========================================
  Files          43       43              
  Lines        6724     6737      +13     
==========================================
+ Hits         6065     6079      +14     
+ Misses        659      658       -1     

Flag	Coverage Δ
tests-3.10	90.42% <95.23%> (+0.03%)	⬆️
tests-3.11	90.42% <95.23%> (+0.03%)	⬆️
tests-3.12	90.42% <95.23%> (?)
tests-3.7	?
tests-3.8	90.23% <95.23%> (+0.03%)	⬆️
tests-3.9	90.23% <95.23%> (+0.03%)	⬆️
tests-pypy3.9	90.34% <90.47%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ming/base.py	98.01% <ø> (ø)
ming/mim.py	79.03% <100.00%> (+0.25%)	⬆️
ming/odm/mapper.py	89.36% <ø> (ø)
ming/orm/__init__.py	100.00% <ø> (ø)
ming/orm/base.py	0.00% <ø> (ø)
ming/orm/declarative.py	0.00% <ø> (ø)
ming/orm/middleware.py	0.00% <ø> (ø)
ming/orm/ormsession.py	0.00% <ø> (ø)
ming/orm/property.py	0.00% <ø> (ø)
ming/tests/test_mim.py	91.36% <100.00%> (+0.06%)	⬆️
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brondsem]

The python 3.12 build failed on formencode trying to import pkg_resources. I did some googling about pkg_resources and python 3.12 and found:

• https://docs.python.org/3/whatsnew/3.12.html says it changed:

Do not pre-install setuptools in virtual environments created with venv. This means that distutils, setuptools, pkg_resources, and easy_install will no longer available by default; to access these run pip install setuptools in the activated virtual environment.

• other people have run into similar issues with other packages too, for example Package fails import on Python 3.12, missing dependencies microsoft/azure-devops-python-api#470

So we probably need ming to have setuptools listed as a dependency. It'd be better if formencode declared its dependency on setuptools but it doesn't :(

[amol-]

@brondsem I'll try to get this into Formencode itself, Ming is not the only library depending on formencode for validation so it would probably benefit a wider audience of projects if the change is upstreamed.

[amol-]

Actually it seems this is not happening in formencode master https://github.com/formencode/formencode/actions/runs/6497564616/job/17646958673?pr=180#step:4:25

[brondsem]

In that output I see Collecting setuptools (from pycountry->-r requirements-test.txt (line 4)) so I think its getting it from there

[amol-]

In that output I see Collecting setuptools (from pycountry->-r requirements-test.txt (line 4)) so I think its getting it from there

That happens after formencode was already installed. My understanding is that the issue reported was that it couldn't even install

[brondsem]

Here's the error we encountered: https://github.com/TurboGears/Ming/actions/runs/6462007528/job/17543400479#step:6:741 It was at runtime, after installation.

[amol-]

@brondsem Formencode 2.1 was release that should address this problem. Can you confirm the error wouldn't happen again even without the explicit setuptools dependency in Ming?

[brondsem]

Yep, it works, nice!

Tested with python3.12 pip install Ming==0.13.0 'formencode<2.1' errors on python -c 'import ming; ming.config.configure(**{"ming":{}})' but with pip install Ming==0.13.0 'formencode==2.1' it works fine.