Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit docs #13

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Edit docs #13

merged 7 commits into from
Feb 20, 2024

Conversation

gnawin
Copy link
Member

@gnawin gnawin commented Feb 19, 2024

Give links to contributing and developer guidelines.

Closes #12

@gnawin gnawin requested review from clizbe and removed request for clizbe February 19, 2024 13:20
@gnawin gnawin marked this pull request as draft February 19, 2024 13:31
@gnawin
Copy link
Member Author

gnawin commented Feb 19, 2024

@abelsiqueira I successfully built the docs locally, but something is wrong online. Any ideas?

docs/src/contributing.md Outdated Show resolved Hide resolved
docs/src/developer.md Outdated Show resolved Hide resolved
@abelsiqueira abelsiqueira dismissed their stale review February 19, 2024 13:40

I'll leave this to Lauren

@gnawin gnawin marked this pull request as ready for review February 19, 2024 14:00
Copy link
Member

@clizbe clizbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, but can be even simpler!

docs/src/contributing.md Outdated Show resolved Hide resolved
@gnawin gnawin requested a review from clizbe February 19, 2024 16:24
Copy link
Member

@clizbe clizbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clizbe clizbe merged commit b9c2f21 into TulipaEnergy:main Feb 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change readme.dev & contributing to link to TulipaEnergyModel
3 participants