Always attach efficiencies to flows

[gnawin]

Pull request details

Describe the changes made in this pull request

add_efficiency is used to create three sets for flows: lowest resolution without efficiencies, lowest resolution with efficiencies, and highest resolution without efficiencies.

• Remove add_efficiency, so flows are always attached with efficiencies. At some cases, the efficiencies are set to 1. @datejada Would you double-check the conditions (by the variable flag) I added?

To still be able to have the set highest resolution without efficiencies

• Add use_highest_resolution. We can open another issue if we want to get rid of this flag as well.

Also a minor edit

• Add an empty line after log display

List of related issues or pull requests

Closes #436

Collaboration confirmation

As a contributor I confirm

• I read and followed the instructions in README.dev.md
• The documentation is up to date with the changes introduced in this Pull Request (or NA)
• Tests are passing
• Lint is passing

[datejada]

I like the changes, thanks! It is more straightforward for the reader to see what is happening. I added some changes in variable names for clarity and consistency.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00a45de) 100.00% compared to head (7b285a8) 100.00%.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #442   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          528       526    -2     
=========================================
- Hits           528       526    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.