Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_machine In Install Script #578

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

mahirpiy
Copy link
Contributor

@mahirpiy mahirpiy commented Jul 12, 2024

Fixes #565 using the change suggested by @scastria (#565 (comment))

@mahirpiy mahirpiy changed the title Fix Checksum Issues on Install Script Fix get_machine In Install Script Jul 12, 2024
@reuvenharrison
Copy link
Collaborator

Thanks for your contribution :-)

@reuvenharrison reuvenharrison merged commit df124e0 into Tufin:main Jul 12, 2024
7 checks passed
@mahirpiy
Copy link
Contributor Author

@reuvenharrison do you think this could be released soon? currently hard blocks my team on something, would love to get it over the line

@reuvenharrison
Copy link
Collaborator

Hi @mahirpiy,
I just released it: https://github.com/Tufin/oasdiff/releases/tag/v1.10.20
It would be great if you could share how you are using it.
Reuven

@mahirpiy
Copy link
Contributor Author

mahirpiy commented Jul 15, 2024

@reuvenharrison thank you!!

my team uses the install script in our CI runner to detect any changes made to our api contracts. we use the generated diff to send a message in an api-changes slack channel, so our client engineers are aware of changes. its part of a bigger api-compatibility overhaul that has our mobile engineers creating data classes directly from the open api yaml. thanks for all you do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checksums do not match while using install script.
2 participants