Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param type/format changes #570

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jun 29, 2024

This PR adds a new check for parameters that are passed as objects and their type is modified.
Fixes #567

@reuvenharrison reuvenharrison linked an issue Jun 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 92.14286% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (68ee79d) to head (6352ef6).

Files Patch % Lines
checker/check_types.go 87.14% 7 Missing and 2 partials ⚠️
checker/check_request_property_type_changed.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
+ Coverage   84.80%   84.91%   +0.11%     
==========================================
  Files         227      228       +1     
  Lines       12963    12980      +17     
==========================================
+ Hits        10993    11022      +29     
+ Misses       1563     1552      -11     
+ Partials      407      406       -1     
Flag Coverage Δ
unittests 84.91% <92.14%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 7760b95 into main Jun 29, 2024
16 checks passed
@reuvenharrison reuvenharrison deleted the 567-no-breaking-change-reported-in-referenced-query-parameter branch June 29, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No breaking change reported in referenced query parameter
1 participant