Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change constructors #569

Merged
merged 25 commits into from
Jul 4, 2024
Merged

change constructors #569

merged 25 commits into from
Jul 4, 2024

Conversation

reuvenharrison
Copy link
Collaborator

@reuvenharrison reuvenharrison commented Jun 26, 2024

This PR adds constructors for the Change objects: ApiChange, ComponentChange and SecurityChange.
Goals:

  • reuse code and eliminate bugs
  • set Level automatically
  • add a new field: custom attributes

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 86.71288% with 230 lines in your changes missing coverage. Please review.

Project coverage is 85.90%. Comparing base (e2e437b) to head (b0670ce).
Report is 1 commits behind head on main.

Files Patch % Lines
...cker/check_request_property_min_items_increased.go 0.00% 20 Missing ⚠️
checker/check_request_property_min_items_set.go 0.00% 20 Missing ⚠️
checker/check_request_property_min_set.go 0.00% 20 Missing ⚠️
checker/check_request_property_min_updated.go 50.00% 20 Missing ⚠️
checker/check_response_property_max_increased.go 0.00% 20 Missing ⚠️
checker/check_response_property_min_decreased.go 0.00% 20 Missing ⚠️
checker/check_response_property_min_items_unset.go 0.00% 20 Missing ⚠️
...ecker/check_request_header_property_became_enum.go 50.00% 10 Missing ⚠️
...r/check_request_header_property_became_required.go 50.00% 10 Missing ⚠️
checker/check_request_parameters_max_set.go 0.00% 10 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   84.91%   85.90%   +0.98%     
==========================================
  Files         228      228              
  Lines       12976    12984       +8     
==========================================
+ Hits        11019    11154     +135     
+ Misses       1551     1415     -136     
- Partials      406      415       +9     
Flag Coverage Δ
unittests 85.90% <86.71%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuvenharrison reuvenharrison merged commit 2a50ce0 into main Jul 4, 2024
16 checks passed
@reuvenharrison reuvenharrison deleted the change-constructors branch July 4, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant